ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix the undefined error when uninstalling extension (#4258)

Browse Source
This commit is contained in:
Alan Ren
2019-03-01 13:58:00 -08:00
committed by GitHub
parent 8ebf5dbcb4
commit 220685a522
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/sql/workbench/services/notebook/common/notebookServiceImpl.ts
View File

@@ -158,7 +158,7 @@ export class NotebookService extends Disposable implements INotebookService {
}
private hookNotebookThemesAndConfigListener(): void {
if(this._configurationService) {
if (this._configurationService) {
this.updateNotebookThemes();
this._register(this._configurationService.onDidChangeConfiguration(e => {
if (e.affectsConfiguration(OVERRIDE_EDITOR_THEMING_SETTING)) {
@@ -458,11 +458,14 @@ export class NotebookService extends Disposable implements INotebookService {
}
private removeContributedProvidersFromCache(identifier: IExtensionIdentifier, extensionService: IExtensionService) {
const notebookProvider = 'notebookProvider';
let extensionid = getIdFromLocalExtensionId(identifier.id);
extensionService.getExtensions().then(i => {
let extension = i.find(c => c.id === extensionid);
if (extension && extension.contributes['notebookProvider']) {
let id = extension.contributes['notebookProvider'].providerId;
if (extension && extension.contributes
&& extension.contributes[notebookProvider]
&& extension.contributes[notebookProvider].providerId) {
let id = extension.contributes[notebookProvider].providerId;
delete this.providersMemento.notebookProviderCache[id];
}
});