mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-04-01 01:20:31 -04:00
We can't authenticate to every subscription (#9826)
* We can't authenticate to every subscription * Refresh tenants and subs when the application starts
This commit is contained in:
@@ -138,29 +138,39 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
|
||||
public dispose() { }
|
||||
|
||||
public async refreshAccess(account: azdata.Account): Promise<azdata.Account> {
|
||||
const response = await this.getCachedToken(account.key);
|
||||
public async refreshAccess(oldAccount: azdata.Account): Promise<azdata.Account> {
|
||||
const response = await this.getCachedToken(oldAccount.key);
|
||||
if (!response) {
|
||||
account.isStale = true;
|
||||
return account;
|
||||
oldAccount.isStale = true;
|
||||
return oldAccount;
|
||||
}
|
||||
|
||||
const refreshToken = response.refreshToken;
|
||||
if (!refreshToken || !refreshToken.key) {
|
||||
account.isStale = true;
|
||||
return account;
|
||||
oldAccount.isStale = true;
|
||||
return oldAccount;
|
||||
}
|
||||
|
||||
try {
|
||||
await this.refreshAccessToken(account.key, refreshToken);
|
||||
// Refresh the access token
|
||||
const tokenResponse = await this.refreshAccessToken(oldAccount.key, refreshToken);
|
||||
const tenants = await this.getTenants(tokenResponse.accessToken);
|
||||
|
||||
// Recreate account object
|
||||
const newAccount = this.createAccount(tokenResponse.tokenClaims, tokenResponse.accessToken.key, tenants);
|
||||
|
||||
const subscriptions = await this.getSubscriptions(newAccount);
|
||||
newAccount.properties.subscriptions = subscriptions;
|
||||
|
||||
return newAccount;
|
||||
} catch (ex) {
|
||||
account.isStale = true;
|
||||
oldAccount.isStale = true;
|
||||
if (ex.message) {
|
||||
await vscode.window.showErrorMessage(ex.message);
|
||||
}
|
||||
console.log(ex);
|
||||
}
|
||||
return account;
|
||||
return oldAccount;
|
||||
}
|
||||
|
||||
|
||||
@@ -375,7 +385,7 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
}
|
||||
}
|
||||
|
||||
private async refreshAccessToken(account: azdata.AccountKey, rt: RefreshToken, tenant?: Tenant, resource?: Resource): Promise<void> {
|
||||
private async refreshAccessToken(account: azdata.AccountKey, rt: RefreshToken, tenant?: Tenant, resource?: Resource): Promise<TokenRefreshResponse> {
|
||||
const postData: { [key: string]: string } = {
|
||||
grant_type: 'refresh_token',
|
||||
refresh_token: rt.token,
|
||||
@@ -387,7 +397,10 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
postData.resource = resource.endpoint;
|
||||
}
|
||||
|
||||
const { accessToken, refreshToken } = await this.getToken(postData, tenant?.id, resource?.id);
|
||||
const getTokenResponse = await this.getToken(postData, tenant?.id, resource?.id);
|
||||
|
||||
const accessToken = getTokenResponse?.accessToken;
|
||||
const refreshToken = getTokenResponse?.refreshToken;
|
||||
|
||||
if (!accessToken || !refreshToken) {
|
||||
console.log('Access or refresh token were undefined');
|
||||
@@ -395,7 +408,9 @@ export abstract class AzureAuth implements vscode.Disposable {
|
||||
throw new Error(msg);
|
||||
}
|
||||
|
||||
return this.setCachedToken(account, accessToken, refreshToken, resource?.id, tenant?.id);
|
||||
await this.setCachedToken(account, accessToken, refreshToken, resource?.id, tenant?.id);
|
||||
|
||||
return getTokenResponse;
|
||||
}
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user