From 22c315ea62bce98fdd9942bda46aa725b70df888 Mon Sep 17 00:00:00 2001 From: Leila Lali Date: Wed, 8 Jun 2022 16:06:00 -0700 Subject: [PATCH] Fixing the telemetry property docker image name (#19685) --- .../src/controllers/projectController.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/extensions/sql-database-projects/src/controllers/projectController.ts b/extensions/sql-database-projects/src/controllers/projectController.ts index 7c8985166f..2a16a288f5 100644 --- a/extensions/sql-database-projects/src/controllers/projectController.ts +++ b/extensions/sql-database-projects/src/controllers/projectController.ts @@ -319,9 +319,12 @@ export class ProjectsController { */ public async publishToDockerContainer(context: Project | dataworkspace.WorkspaceTreeItem, deployProfile: ILocalDbDeployProfile): Promise { const project: Project = this.getProjectFromContext(context); + // Removing the path separator from the image base name to be able to add that in the telemetry. With the separator the name is flagged as user path which is not true + // We only need to know the image base parts so it's ok to use a different separator when adding to telemetry + const dockerImageNameForTelemetry = deployProfile.localDbSetting?.dockerBaseImage ? deployProfile.localDbSetting.dockerBaseImage.replace(/\//gi, '_') : ''; try { TelemetryReporter.createActionEvent(TelemetryViews.ProjectController, TelemetryActions.publishToContainer) - .withAdditionalProperties({ dockerBaseImage: deployProfile.localDbSetting!.dockerBaseImage }) + .withAdditionalProperties({ dockerBaseImage: dockerImageNameForTelemetry }) .send(); if (deployProfile && deployProfile.deploySettings) { @@ -351,7 +354,7 @@ export class ProjectsController { } catch (error) { void utils.showErrorMessageWithOutputChannel(constants.publishToContainerFailed, error, this._outputChannel); TelemetryReporter.createErrorEvent(TelemetryViews.ProjectController, TelemetryActions.publishToContainer) - .withAdditionalProperties({ dockerBaseImage: deployProfile.localDbSetting!.dockerBaseImage }) + .withAdditionalProperties({ dockerBaseImage: dockerImageNameForTelemetry }) .send(); } return;