Strict Null Checks, Builder Removal, Formatting (#4849)

* remove builder; more null checks

* null checks

* formatting

* wip

* fix dropdown themeing

* formatting

* formatting

* fix tests

* update what files are checked

* add code to help refresh bad nodes

src/sql/base/common/decorators.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 /**
  * Alterable version of the vs memorize function; to unmemoize use unmemoize
 */

src/sql/base/common/eventEmitter.ts

@@ -2,9 +2,8 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
-import Errors = require('vs/base/common/errors');
+import * as errors from 'vs/base/common/errors';
 import { IDisposable } from 'vs/base/common/lifecycle';
 
 export class EmitterEvent {
@@ -288,7 +287,7 @@ function safeInvokeNoArg<T>(func: Function): T | undefined {
 	try {
 		return func();
 	} catch (e) {
-		Errors.onUnexpectedError(e);
+		errors.onUnexpectedError(e);
 	}
 	return undefined;
 }
@@ -297,6 +296,6 @@ function safeInvoke1Arg(func: Function, arg1: any): any {
 	try {
 		return func(arg1);
 	} catch (e) {
-		Errors.onUnexpectedError(e);
+		errors.onUnexpectedError(e);
 	}
 }

src/sql/base/common/log.ts

@@ -3,8 +3,6 @@
 *  Licensed under the Source EULA. See License.txt in the project root for license information.
 *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 export function log(...args: any[]): void {
 	console.log(`\x1b[90m[main ${new Date().toLocaleTimeString()}]\x1b[0m`, ...args);
 }

src/sql/base/common/map.ts

@@ -3,8 +3,6 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
-'use strict';
-
 export function toObject<V>(map: Map<string, V>): { [key: string]: V } {
 	if (map) {
 		let rt: { [key: string]: V } = Object.create(null);

src/sql/base/common/objects.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
+
 import * as Types from 'vs/base/common/types';
 
 export function clone<T>(obj: T): T {

src/sql/base/common/promise.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 /**
  * Deferred promise
@@ -23,4 +22,4 @@ export class Deferred<T> {
 	then<TResult>(onfulfilled?: (value: T) => TResult | Thenable<TResult>, onrejected?: (reason: any) => TResult | Thenable<TResult> | void): Thenable<TResult> {
 		return this.promise.then(onfulfilled, onrejected);
 	}
-}
+}

src/sql/base/common/strings.ts

@@ -2,7 +2,6 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-'use strict';
 
 /**
  * Converts HTML characters inside the string to use entities instead. Makes the string safe from