ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-11 10:38:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

Strict Null Checks, Builder Removal, Formatting (#4849)

Browse Source 
* remove builder; more null checks

* null checks

* formatting

* wip

* fix dropdown themeing

* formatting

* formatting

* fix tests

* update what files are checked

* add code to help refresh bad nodes
This commit is contained in:
Anthony Dresser
2019-04-08 13:27:41 -07:00
committed by GitHub
parent 01784dd186
commit 22ec1d5f0a
57 changed files with 177 additions and 206 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/vs/platform/contextkey/common/contextkey.ts
View File

@@ -622,8 +622,12 @@ export class ContextKeyGreaterThanEqualsExpr implements ContextKeyExpr {
}
public evaluate(context: IContext): boolean {
let keyInt = parseFloat(context.getValue(this.key));
let valueInt = parseFloat(this.value);
const keyVal = context.getValue<string>(this.key);
if (!keyVal) {
return false;
}
const keyInt = parseFloat(keyVal);
const valueInt = parseFloat(this.value);
return (keyInt >= valueInt);
}
@@ -677,8 +681,12 @@ export class ContextKeyLessThanEqualsExpr implements ContextKeyExpr {
}
public evaluate(context: IContext): boolean {
let keyInt = parseFloat(context.getValue(this.key));
let valueInt = parseFloat(this.value);
const keyVal = context.getValue<string>(this.key);
if (!keyVal) {
return false;
}
const keyInt = parseFloat(keyVal);
const valueInt = parseFloat(this.value);
return (keyInt <= valueInt);
}