From 230c0f317faafb98a56b79bf8f24938af5416d18 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Thu, 3 Feb 2022 09:48:06 -0800 Subject: [PATCH] Notebooks: Add telemetry event for mime type renderer not found (#18200) * Add event for mime type renderer not found * Add back missing return statement --- src/sql/platform/telemetry/common/telemetryKeys.ts | 3 ++- .../contrib/notebook/browser/cellViews/output.component.ts | 5 ++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/sql/platform/telemetry/common/telemetryKeys.ts b/src/sql/platform/telemetry/common/telemetryKeys.ts index bce1b5e89b..a71900369a 100644 --- a/src/sql/platform/telemetry/common/telemetryKeys.ts +++ b/src/sql/platform/telemetry/common/telemetryKeys.ts @@ -101,7 +101,8 @@ export const enum NbTelemetryAction { KernelChanged = 'KernelChanged', NewNotebookFromConnections = 'NewNotebookWithConnectionProfile', UndoCell = 'UndoCell', - RedoCell = 'RedoCell' + RedoCell = 'RedoCell', + MIMETypeRendererNotFound = 'MIMETypeRendererNotFound' } export const enum TelemetryPropertyName { diff --git a/src/sql/workbench/contrib/notebook/browser/cellViews/output.component.ts b/src/sql/workbench/contrib/notebook/browser/cellViews/output.component.ts index 594e724adf..46735fa4bd 100644 --- a/src/sql/workbench/contrib/notebook/browser/cellViews/output.component.ts +++ b/src/sql/workbench/contrib/notebook/browser/cellViews/output.component.ts @@ -23,6 +23,7 @@ import { getErrorMessage } from 'vs/base/common/errors'; import { CellView, findHighlightClass, findRangeSpecificClass } from 'sql/workbench/contrib/notebook/browser/cellViews/interfaces'; import { INotebookService, NotebookRange } from 'sql/workbench/services/notebook/browser/notebookService'; import { NotebookInput } from 'sql/workbench/contrib/notebook/browser/models/notebookInput'; +import * as TelemetryKeys from 'sql/platform/telemetry/common/telemetryKeys'; export const OUTPUT_SELECTOR: string = 'output-component'; const USER_SELECT_CLASS = 'actionselect'; @@ -152,9 +153,11 @@ export class OutputComponent extends CellView implements OnInit, AfterViewInit { ); this.errorText = undefined; if (!mimeType) { + const mimeTypesWithoutRenderer = Object.keys(options.data); this.errorText = localize('noMimeTypeFound', "No {0}renderer could be found for output. It has the following MIME types: {1}", options.trusted ? '' : localize('safe', "safe "), - Object.keys(options.data).join(', ')); + mimeTypesWithoutRenderer.join(', ')); + this.cellModel?.notebookModel?.sendNotebookTelemetryActionEvent(TelemetryKeys.NbTelemetryAction.MIMETypeRendererNotFound, { mime_types: mimeTypesWithoutRenderer }); return; } let selector = componentRegistry.getCtorFromMimeType(mimeType);