Initial VS Code 1.19 source merge (#571)

* Initial 1.19 xcopy

* Fix yarn build

* Fix numerous build breaks

* Next batch of build break fixes

* More build break fixes

* Runtime breaks

* Additional post merge fixes

* Fix windows setup file

* Fix test failures.

* Update license header blocks to refer to source eula

src/sql/parts/accountManagement/accountDialog/accountDialog.ts

@@ -10,7 +10,7 @@ import 'vs/css!sql/parts/accountManagement/common/media/accountActions';
 import * as DOM from 'vs/base/browser/dom';
 import { SplitView } from 'sql/base/browser/ui/splitview/splitview';
 import { List } from 'vs/base/browser/ui/list/listWidget';
-import { IListService } from 'vs/platform/list/browser/listService';
+import { IListService, ListService } from 'vs/platform/list/browser/listService';
 import { IPartService } from 'vs/workbench/services/part/common/partService';
 import Event, { Emitter } from 'vs/base/common/event';
 import { localize } from 'vs/nls';
@@ -192,7 +192,9 @@ export class AccountDialog extends Modal {
 		// Append the list view to the split view
 		this._splitView.addView(providerView);
 		this._register(attachListStyler(accountList, this._themeService));
-		this._register(this._listService.register(accountList));
+
+		let listService = <ListService>this._listService;
+		this._register(listService.register(accountList));
 		this._splitView.layout(DOM.getContentHeight(this._container));
 
 		// Set the initial items of the list

src/sql/parts/accountManagement/autoOAuthDialog/autoOAuthDialog.ts

@@ -64,7 +64,7 @@ export class AutoOAuthDialog extends Modal {
 	public render() {
 		super.render();
 		attachModalDialogStyler(this, this._themeService);
-		this.backButton.addListener('click', () => this.cancel());
+		this.backButton.onDidClick(() => this.cancel());
 		this._register(attachButtonStyler(this.backButton, this._themeService, { buttonBackground: SIDE_BAR_BACKGROUND, buttonHoverBackground: SIDE_BAR_BACKGROUND }));
 
 		this._copyAndOpenButton = this.addFooterButton(localize('copyAndOpen', 'Copy & Open'), () => this.addAccount());

src/sql/parts/accountManagement/common/accountActions.ts

@@ -97,26 +97,23 @@ export class RemoveAccountAction extends Action {
 			type: 'question'
 		};
 
-		let confirmPromise = this._messageService.confirm(confirm);
-
-		return confirmPromise.then(confirmation => {
-			if (!confirmation.confirmed) {
-				return TPromise.as(false);
-			} else {
-				return new TPromise((resolve, reject) => {
-					self._accountManagementService.removeAccount(self._account.key)
-						.then(
-							(result) => { resolve(result); },
-							(err) => {
-								// Must handle here as this is an independent action
-								self._errorMessageService.showDialog(Severity.Error,
-									localize('removeAccountFailed', 'Failed to remove account'), err);
-								resolve(false);
-							}
-						);
-				});
-			}
-		});
+		let confirmPromise: boolean = this._messageService.confirm(confirm);
+		if (!confirmPromise) {
+			return TPromise.as(false);
+		} else {
+			return new TPromise((resolve, reject) => {
+				self._accountManagementService.removeAccount(self._account.key)
+					.then(
+						(result) => { resolve(result); },
+						(err) => {
+							// Must handle here as this is an independent action
+							self._errorMessageService.showDialog(Severity.Error,
+								localize('removeAccountFailed', 'Failed to remove account'), err);
+							resolve(false);
+						}
+					);
+			});
+		}
 	}
 }
 

src/sql/parts/accountManagement/firewallRuleDialog/firewallRuleDialog.ts

@@ -90,7 +90,7 @@ export class FirewallRuleDialog extends Modal {
 	public render() {
 		super.render();
 		attachModalDialogStyler(this, this._themeService);
-		this.backButton.addListener('click', () => this.cancel());
+		this.backButton.onDidClick(() => this.cancel());
 		this._register(attachButtonStyler(this.backButton, this._themeService, { buttonBackground: SIDE_BAR_BACKGROUND, buttonHoverBackground: SIDE_BAR_BACKGROUND }));
 		this._createButton = this.addFooterButton(localize('ok', 'OK'), () => this.createFirewallRule());
 		this._closeButton = this.addFooterButton(localize('cancel', 'Cancel'), () => this.cancel());