Initial VS Code 1.19 source merge (#571)

* Initial 1.19 xcopy

* Fix yarn build

* Fix numerous build breaks

* Next batch of build break fixes

* More build break fixes

* Runtime breaks

* Additional post merge fixes

* Fix windows setup file

* Fix test failures.

* Update license header blocks to refer to source eula

src/vs/workbench/browser/actions/toggleActivityBarVisibility.ts

@@ -15,10 +15,10 @@ import { IPartService, Parts } from 'vs/workbench/services/part/common/partServi
 
 export class ToggleActivityBarVisibilityAction extends Action {
 
-	public static ID = 'workbench.action.toggleActivityBarVisibility';
-	public static LABEL = nls.localize('toggleActivityBar', "Toggle Activity Bar Visibility");
+	public static readonly ID = 'workbench.action.toggleActivityBarVisibility';
+	public static readonly LABEL = nls.localize('toggleActivityBar', "Toggle Activity Bar Visibility");
 
-	private static activityBarVisibleKey = 'workbench.activityBar.visible';
+	private static readonly activityBarVisibleKey = 'workbench.activityBar.visible';
 
 	constructor(
 		id: string,

src/vs/workbench/browser/actions/toggleEditorLayout.ts

@@ -19,8 +19,8 @@ import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation
 
 export class ToggleEditorLayoutAction extends Action {
 
-	public static ID = 'workbench.action.toggleEditorGroupLayout';
-	public static LABEL = nls.localize('toggleEditorGroupLayout', "Toggle Editor Group Vertical/Horizontal Layout");
+	public static readonly ID = 'workbench.action.toggleEditorGroupLayout';
+	public static readonly LABEL = nls.localize('toggleEditorGroupLayout', "Toggle Editor Group Vertical/Horizontal Layout");
 
 	private toDispose: IDisposable[];
 

src/vs/workbench/browser/actions/toggleSidebarPosition.ts

@@ -15,10 +15,10 @@ import { IConfigurationService, ConfigurationTarget } from 'vs/platform/configur
 
 export class ToggleSidebarPositionAction extends Action {
 
-	public static ID = 'workbench.action.toggleSidebarPosition';
-	public static LABEL = nls.localize('toggleLocation', "Toggle Side Bar Location");
+	public static readonly ID = 'workbench.action.toggleSidebarPosition';
+	public static readonly LABEL = nls.localize('toggleLocation', "Toggle Side Bar Location");
 
-	private static sidebarPositionConfigurationKey = 'workbench.sideBar.location';
+	private static readonly sidebarPositionConfigurationKey = 'workbench.sideBar.location';
 
 	constructor(
 		id: string,

src/vs/workbench/browser/actions/toggleSidebarVisibility.ts

@@ -15,8 +15,8 @@ import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
 
 export class ToggleSidebarVisibilityAction extends Action {
 
-	public static ID = 'workbench.action.toggleSidebarVisibility';
-	public static LABEL = nls.localize('toggleSidebar', "Toggle Side Bar Visibility");
+	public static readonly ID = 'workbench.action.toggleSidebarVisibility';
+	public static readonly LABEL = nls.localize('toggleSidebar', "Toggle Side Bar Visibility");
 
 	constructor(
 		id: string,

src/vs/workbench/browser/actions/toggleStatusbarVisibility.ts

@@ -15,10 +15,10 @@ import { IPartService, Parts } from 'vs/workbench/services/part/common/partServi
 
 export class ToggleStatusbarVisibilityAction extends Action {
 
-	public static ID = 'workbench.action.toggleStatusbarVisibility';
-	public static LABEL = nls.localize('toggleStatusbar', "Toggle Status Bar Visibility");
+	public static readonly ID = 'workbench.action.toggleStatusbarVisibility';
+	public static readonly LABEL = nls.localize('toggleStatusbar', "Toggle Status Bar Visibility");
 
-	private static statusbarVisibleKey = 'workbench.statusBar.visible';
+	private static readonly statusbarVisibleKey = 'workbench.statusBar.visible';
 
 	constructor(
 		id: string,

src/vs/workbench/browser/actions/toggleTabsVisibility.ts

@@ -0,0 +1,40 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the Source EULA. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+'use strict';
+
+import { TPromise } from 'vs/base/common/winjs.base';
+import nls = require('vs/nls');
+import { Registry } from 'vs/platform/registry/common/platform';
+import { Action } from 'vs/base/common/actions';
+import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
+import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actions';
+import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
+import { KeyCode, KeyMod } from 'vs/base/common/keyCodes';
+
+export class ToggleTabsVisibilityAction extends Action {
+
+	public static readonly ID = 'workbench.action.toggleTabsVisibility';
+	public static readonly LABEL = nls.localize('toggleTabs', "Toggle Tab Visibility");
+
+	private static readonly tabsVisibleKey = 'workbench.editor.showTabs';
+
+	constructor(
+		id: string,
+		label: string,
+		@IConfigurationService private configurationService: IConfigurationService
+	) {
+		super(id, label);
+	}
+
+	public run(): TPromise<any> {
+		const visibility = this.configurationService.getValue<string>(ToggleTabsVisibilityAction.tabsVisibleKey);
+		const newVisibilityValue = !visibility;
+
+		return this.configurationService.updateValue(ToggleTabsVisibilityAction.tabsVisibleKey, newVisibilityValue);
+	}
+}
+
+const registry = Registry.as<IWorkbenchActionRegistry>(Extensions.WorkbenchActions);
+registry.registerWorkbenchAction(new SyncActionDescriptor(ToggleTabsVisibilityAction, ToggleTabsVisibilityAction.ID, ToggleTabsVisibilityAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.WinCtrl | KeyCode.KEY_W }), 'View: Toggle Tab Visibility', nls.localize('view', "View"));

src/vs/workbench/browser/actions/toggleZenMode.ts

@@ -14,8 +14,8 @@ import { IPartService } from 'vs/workbench/services/part/common/partService';
 
 class ToggleZenMode extends Action {
 
-	public static ID = 'workbench.action.toggleZenMode';
-	public static LABEL = nls.localize('toggleZenMode', "Toggle Zen Mode");
+	public static readonly ID = 'workbench.action.toggleZenMode';
+	public static readonly LABEL = nls.localize('toggleZenMode', "Toggle Zen Mode");
 
 	constructor(
 		id: string,

src/vs/workbench/browser/actions/workspaceActions.ts

@@ -14,7 +14,7 @@ import { IWorkspaceContextService, WorkbenchState, IWorkspaceFolder } from 'vs/p
 import { IWorkspaceEditingService } from 'vs/workbench/services/workspace/common/workspaceEditing';
 import URI from 'vs/base/common/uri';
 import { IViewletService } from 'vs/workbench/services/viewlet/browser/viewlet';
-import { IInstantiationService, ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
+import { ServicesAccessor } from 'vs/platform/instantiation/common/instantiation';
 import { WORKSPACE_FILTER, IWorkspacesService } from 'vs/platform/workspaces/common/workspaces';
 import { IEnvironmentService } from 'vs/platform/environment/common/environment';
 import { isLinux } from 'vs/base/common/platform';
@@ -204,7 +204,6 @@ export class AddRootFolderAction extends BaseWorkspacesAction {
 		@IWindowService windowService: IWindowService,
 		@IWorkspaceContextService contextService: IWorkspaceContextService,
 		@IEnvironmentService environmentService: IEnvironmentService,
-		@IInstantiationService private instantiationService: IInstantiationService,
 		@IWorkspaceEditingService private workspaceEditingService: IWorkspaceEditingService,
 		@IViewletService private viewletService: IViewletService,
 		@IHistoryService historyService: IHistoryService
@@ -367,8 +366,8 @@ export class OpenWorkspaceAction extends Action {
 
 export class OpenWorkspaceConfigFileAction extends Action {
 
-	public static ID = 'workbench.action.openWorkspaceConfigFile';
-	public static LABEL = nls.localize('openWorkspaceConfigFile', "Open Workspace Configuration File");
+	public static readonly ID = 'workbench.action.openWorkspaceConfigFile';
+	public static readonly LABEL = nls.localize('openWorkspaceConfigFile', "Open Workspace Configuration File");
 
 	constructor(
 		id: string,
@@ -388,8 +387,8 @@ export class OpenWorkspaceConfigFileAction extends Action {
 
 export class OpenFolderAsWorkspaceInNewWindowAction extends Action {
 
-	public static ID = 'workbench.action.openFolderAsWorkspaceInNewWindow';
-	public static LABEL = nls.localize('openFolderAsWorkspaceInNewWindow', "Open Folder as Workspace in New Window");
+	public static readonly ID = 'workbench.action.openFolderAsWorkspaceInNewWindow';
+	public static readonly LABEL = nls.localize('openFolderAsWorkspaceInNewWindow', "Open Folder as Workspace in New Window");
 
 	constructor(
 		id: string,