Merge vscode source through 1.62 release (#19981)

* Build breaks 1

* Build breaks

* Build breaks

* Build breaks

* More build breaks

* Build breaks (#2512)

* Runtime breaks

* Build breaks

* Fix dialog location break

* Update typescript

* Fix ASAR break issue

* Unit test breaks

* Update distro

* Fix breaks in ADO builds (#2513)

* Bump to node 16

* Fix hygiene errors

* Bump distro

* Remove reference to node type

* Delete vscode specific extension

* Bump to node 16 in CI yaml

* Skip integration tests in CI builds (while fixing)

* yarn.lock update

* Bump moment dependency in remote yarn

* Fix drop-down chevron style

* Bump to node 16

* Remove playwrite from ci.yaml

* Skip building build scripts in hygine check

test/smoke/README.md

@@ -27,7 +27,7 @@ example: yarn smoketest --build /Applications/Visual\ Studio\ Code\ -\ Insiders.
 # Build (Web - read instructions below)
 yarn smoketest --build <path to server web build (ends in -web)> --web --browser [chromium|webkit]
 
-# Remote (Electron)
+# Remote (Electron - Must be run on distro)
 yarn smoketest --build <path to latest version> --remote
 ```
 
@@ -63,6 +63,8 @@ xattr -d com.apple.quarantine <path to server with web folder zip>
 - `-f PATTERN` (alias `-g PATTERN`) filters the tests to be run. This is sent to Mocha as the [grep](https://mochajs.org/api/mocha#grep) option, typically you can just use a simple string of the test name to filter down to just that test (e.g. `test -f "My Test Name"`)
 - `--screenshots SCREENSHOT_DIR` captures screenshots when tests fail.
 
+**Note**: you can enable verbose logging of playwright library by setting a `DEBUG` environment variable before running the tests (https://playwright.dev/docs/debug#verbose-api-logs)
+
 ### Develop
 
 ```bash
@@ -80,7 +82,7 @@ On Windows, check for the folder `C:\Users\<username>\AppData\Local\Temp\t`. If
 
 - Beware of workbench **state**. The tests within a single suite will share the same state.
 
-- Beware of **singletons**. This evil can, and will, manifest itself under the form of FS paths, TCP ports, IPC handles. Whenever writing a test, or setting up more smoke test architecture, make sure it can run simultaneously with any other tests and even itself.	All test suites should be able to run many times in parallel.
+- Beware of **singletons**. This evil can, and will, manifest itself under the form of FS paths, TCP ports, IPC handles. Whenever writing a test, or setting up more smoke test architecture, make sure it can run simultaneously with any other tests and even itself. All test suites should be able to run many times in parallel.
 
 - Beware of **focus**. **Never** depend on DOM elements having focus using `.focused` classes or `:focus` pseudo-classes, since they will lose that state as soon as another window appears on top of the running VS Code window. A safe approach which avoids this problem is to use the `waitForActiveElement` API. Many tests use this whenever they need to wait for a specific element to _have focus_.
 

test/smoke/src/areas/search/search.test.ts

@@ -6,7 +6,7 @@
 import * as cp from 'child_process';
 import minimist = require('minimist');
 import { Application } from '../../../../automation';
-import { afterSuite, beforeSuite } from '../../utils';
+import { afterSuite, beforeSuite, retry } from '../../utils';
 
 export function setup(opts: minimist.ParsedArgs) {
 	// https://github.com/microsoft/vscode/issues/115244
@@ -15,8 +15,8 @@ export function setup(opts: minimist.ParsedArgs) {
 
 		after(function () {
 			const app = this.app as Application;
-			cp.execSync('git checkout . --quiet', { cwd: app.workspacePathOrFolder });
-			cp.execSync('git reset --hard HEAD --quiet', { cwd: app.workspacePathOrFolder });
+			retry(async () => cp.execSync('git checkout . --quiet', { cwd: app.workspacePathOrFolder }), 0, 5);
+			retry(async () => cp.execSync('git reset --hard HEAD --quiet', { cwd: app.workspacePathOrFolder }), 0, 5);
 		});
 
 		afterSuite(opts);

test/smoke/src/areas/statusbar/statusbar.test.ts

@@ -65,18 +65,6 @@ export function setup(opts: minimist.ParsedArgs) {
 			await app.workbench.problems.waitForProblemsView();
 		});
 
-		it(`checks if 'Go to Line' works if called from the status bar`, async function () {
-			const app = this.app as Application;
-
-			await app.workbench.quickaccess.openFile('app.js');
-			await app.workbench.statusbar.clickOn(StatusBarElement.SELECTION_STATUS);
-
-			await app.workbench.quickinput.waitForQuickInputOpened();
-
-			await app.workbench.quickinput.submit(':15');
-			await app.workbench.editor.waitForHighlightingLine('app.js', 15);
-		});
-
 		it(`verifies if changing EOL is reflected in the status bar`, async function () {
 			const app = this.app as Application;
 

test/smoke/src/utils.ts

@@ -48,7 +48,11 @@ export function afterSuite(opts: minimist.ParsedArgs) {
 
 		if (this.currentTest?.state === 'failed' && opts.screenshots) {
 			const name = this.currentTest!.fullTitle().replace(/[^a-z0-9\-]/ig, '_');
-			await app.captureScreenshot(name);
+			try {
+				await app.captureScreenshot(name);
+			} catch (error) {
+				// ignore
+			}
 		}
 	});
 
@@ -68,3 +72,23 @@ export function timeout(i: number) {
 		}, i);
 	});
 }
+
+export interface ITask<T> {
+	(): T;
+}
+
+export async function retry<T>(task: ITask<Promise<T>>, delay: number, retries: number): Promise<T> {
+	let lastError: Error | undefined;
+
+	for (let i = 0; i < retries; i++) {
+		try {
+			return await task();
+		} catch (error) {
+			lastError = error;
+
+			await timeout(delay);
+		}
+	}
+
+	throw lastError;
+}