Fix CalloutDialog not opening after bad link (#16051)

* fix null parentNode
This commit is contained in:
Vasu Bhog
2021-07-09 12:01:48 -04:00
committed by GitHub
parent 8f202d91b6
commit 27823e9900

View File

@@ -351,8 +351,12 @@ export class MarkdownToolbarComponent extends AngularDisposable {
private getCurrentLinkUrl(): string {
if (this.cellModel.currentMode === CellEditModes.WYSIWYG) {
const parentNode = document.getSelection().anchorNode.parentNode as HTMLAnchorElement;
if (parentNode.protocol === 'file:') {
const anchorNode = document.getSelection().anchorNode;
if (!anchorNode) {
return '';
}
const parentNode = anchorNode.parentNode as HTMLAnchorElement;
if (parentNode?.protocol === 'file:') {
// Pathname starts with / per https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement/pathname so trim it off
return parentNode.pathname?.slice(1) || '';
} else {