ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix CalloutDialog not opening after bad link (#16051)

Browse Source 
* fix null parentNode
This commit is contained in:
Vasu Bhog
2021-07-09 12:01:48 -04:00
committed by GitHub
parent 8f202d91b6
commit 27823e9900
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sql/workbench/contrib/notebook/browser/cellViews/markdownToolbar.component.ts
View File

@@ -351,8 +351,12 @@ export class MarkdownToolbarComponent extends AngularDisposable {
private getCurrentLinkUrl(): string { private getCurrentLinkUrl(): string {
if (this.cellModel.currentMode === CellEditModes.WYSIWYG) { if (this.cellModel.currentMode === CellEditModes.WYSIWYG) {
const parentNode = document.getSelection().anchorNode.parentNode as HTMLAnchorElement; const anchorNode = document.getSelection().anchorNode;
if (parentNode.protocol === 'file:') { if (!anchorNode) {
return '';
}
const parentNode = anchorNode.parentNode as HTMLAnchorElement;
if (parentNode?.protocol === 'file:') {
// Pathname starts with / per https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement/pathname so trim it off // Pathname starts with / per https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement/pathname so trim it off
return parentNode.pathname?.slice(1) || ''; return parentNode.pathname?.slice(1) || '';
} else { } else {