Implement a no sync rule (#7216)

* implement a no sync rule

* fix linting disable

* fix unused imports

* exclude more testing

* clean up fs usage

* clean up more fs usage

* remove duplicate of code

* fix compile errors

extensions/agent/src/agentUtils.ts

@@ -6,9 +6,7 @@
 'use strict';
 
 import * as azdata from 'azdata';
-import * as fs from 'fs';
-import { promisify } from 'util';
-
+import { promises as fs } from 'fs';
 
 export class AgentUtils {
 
@@ -52,18 +50,11 @@ export class AgentUtils {
 
 }
 
-export function exists(path: string): Promise<boolean> {
-	return promisify(fs.exists)(path);
-}
-
-export function mkdir(path: string): Promise<void> {
-	return promisify(fs.mkdir)(path);
-}
-
-export function unlink(path: string): Promise<void> {
-	return promisify(fs.unlink)(path);
-}
-
-export function writeFile(path: string, data: string): Promise<void> {
-	return promisify(fs.writeFile)(path, data);
+export async function exists(path: string): Promise<boolean> {
+	try {
+		await fs.access(path);
+		return true;
+	} catch (e) {
+		return false;
+	}
 }

extensions/agent/src/data/notebookData.ts

@@ -7,12 +7,10 @@
 import * as nls from 'vscode-nls';
 import * as azdata from 'azdata';
 import * as vscode from 'vscode';
-import * as fs from 'fs';
 import * as path from 'path';
-import { AgentUtils } from '../agentUtils';
+import { AgentUtils, exists } from '../agentUtils';
 import { IAgentDialogData, AgentDialogMode } from '../interfaces';
 import { NotebookDialogOptions } from '../dialogs/notebookDialog';
-import { createConnection } from 'net';
 
 const localize = nls.loadMessageBundle();
 const NotebookCompletionActionCondition_Always: string = localize('notebookData.whenJobCompletes', 'When the notebook completes');
@@ -179,7 +177,7 @@ export class NotebookData implements IAgentDialogData {
 		}
 	}
 
-	public validate(): { valid: boolean, errorMessages: string[] } {
+	public async validate(): Promise<{ valid: boolean, errorMessages: string[] }> {
 		let validationErrors: string[] = [];
 		if (this.dialogMode !== AgentDialogMode.EDIT) {
 			if (!(this.name && this.name.trim())) {
@@ -188,7 +186,7 @@ export class NotebookData implements IAgentDialogData {
 			if (!(this.templatePath && this.name.trim())) {
 				validationErrors.push(TemplatePathEmptyErrorMessage);
 			}
-			if (!fs.existsSync(this.templatePath)) {
+			if (!(await exists(this.templatePath))) {
 				validationErrors.push(InvalidNotebookPathErrorMessage);
 			}
 			if (NotebookData.jobLists) {
@@ -201,7 +199,7 @@ export class NotebookData implements IAgentDialogData {
 			}
 		}
 		else {
-			if (this.templatePath && this.templatePath !== '' && !fs.existsSync(this.templatePath)) {
+			if (this.templatePath && this.templatePath !== '' && !(await exists(this.templatePath))) {
 				validationErrors.push(InvalidNotebookPathErrorMessage);
 			}
 		}

extensions/agent/src/dialogs/notebookDialog.ts

@@ -87,9 +87,9 @@ export class NotebookDialog extends AgentDialog<NotebookData>  {
 		this.generalTab = azdata.window.createTab(GeneralTabText);
 		this.initializeGeneralTab();
 		this.dialog.content = [this.generalTab];
-		this.dialog.registerCloseValidator(() => {
+		this.dialog.registerCloseValidator(async () => {
 			this.updateModel();
-			let validationResult = this.model.validate();
+			let validationResult = await this.model.validate();
 			if (!validationResult.valid) {
 				// TODO: Show Error Messages
 				this.dialog.message = { text: validationResult.errorMessages[0] };

extensions/agent/src/mainController.ts

@@ -7,7 +7,7 @@
 import * as nls from 'vscode-nls';
 import * as azdata from 'azdata';
 import * as vscode from 'vscode';
-import * as fs from 'fs';
+import { promises as fs } from 'fs';
 import * as os from 'os';
 import * as path from 'path';
 import { AlertDialog } from './dialogs/alertDialog';
@@ -17,9 +17,8 @@ import { ProxyDialog } from './dialogs/proxyDialog';
 import { JobStepDialog } from './dialogs/jobStepDialog';
 import { PickScheduleDialog } from './dialogs/pickScheduleDialog';
 import { JobData } from './data/jobData';
-import { AgentUtils, exists, mkdir, unlink, writeFile } from './agentUtils';
+import { AgentUtils, exists } from './agentUtils';
 import { NotebookDialog, NotebookDialogOptions } from './dialogs/notebookDialog';
-import { promisify } from 'util';
 
 
 const localize = nls.loadMessageBundle();
@@ -102,7 +101,7 @@ export class MainController {
 			let templateMap = this.notebookTemplateMap.get(nbEditor.document.uri.toString());
 			let vsEditor = await vscode.workspace.openTextDocument(templateMap.fileUri);
 			let content = vsEditor.getText();
-			promisify(fs.writeFile)(templateMap.tempPath, content);
+			await fs.writeFile(templateMap.tempPath, content);
 			AgentUtils.getAgentService().then(async (agentService) => {
 				let result = await agentService.updateNotebook(templateMap.ownerUri, templateMap.notebookInfo.name, templateMap.notebookInfo, templateMap.tempPath);
 				if (result.success) {
@@ -128,14 +127,13 @@ export class MainController {
 		vscode.commands.registerCommand('agent.openNotebookEditorFromJsonString', async (filename: string, jsonNotebook: string, notebookInfo?: azdata.AgentNotebookInfo, ownerUri?: string) => {
 			const tempfilePath = path.join(os.tmpdir(), 'mssql_notebooks', filename + '.ipynb');
 			if (!await exists(path.join(os.tmpdir(), 'mssql_notebooks'))) {
-				await mkdir(path.join(os.tmpdir(), 'mssql_notebooks'));
+				await fs.mkdir(path.join(os.tmpdir(), 'mssql_notebooks'));
 			}
-			let editors = azdata.nb.visibleNotebookEditors;
 			if (await exists(tempfilePath)) {
-				await unlink(tempfilePath);
+				await fs.unlink(tempfilePath);
 			}
 			try {
-				await writeFile(tempfilePath, jsonNotebook);
+				await fs.writeFile(tempfilePath, jsonNotebook);
 				let uri = vscode.Uri.parse(`untitled:${path.basename(tempfilePath)}`);
 				if (notebookInfo) {
 					this.notebookTemplateMap.set(uri.toString(), { notebookInfo: notebookInfo, fileUri: uri, ownerUri: ownerUri, tempPath: tempfilePath });