ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused things from ads telemetry service (#22016)

Browse Source
This commit is contained in:
Charles Gagnon
2023-02-23 15:34:47 -08:00
committed by GitHub
parent 4ed1ef34b6
commit 290687a207
2 changed files with 1 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/sql/platform/telemetry/common/adsTelemetryService.ts
View File

@@ -6,7 +6,7 @@
import * as azdata from 'azdata'; import * as azdata from 'azdata';
import { IAdsTelemetryService, ITelemetryEvent, ITelemetryEventMeasures, ITelemetryEventProperties } from 'sql/platform/telemetry/common/telemetry'; import { IAdsTelemetryService, ITelemetryEvent, ITelemetryEventMeasures, ITelemetryEventProperties } from 'sql/platform/telemetry/common/telemetry';
import { ILogService } from 'vs/platform/log/common/log'; import { ILogService } from 'vs/platform/log/common/log';
import { ITelemetryInfo, ITelemetryService, TelemetryLevel } from 'vs/platform/telemetry/common/telemetry'; import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
import { EventName } from 'sql/platform/telemetry/common/telemetryKeys'; import { EventName } from 'sql/platform/telemetry/common/telemetryKeys';
@@ -88,23 +88,6 @@ export class AdsTelemetryService implements IAdsTelemetryService {
@ILogService private logService: ILogService @ILogService private logService: ILogService
) { } ) { }
setEnabled(value: boolean): void {
// if (value) {
// this.telemetryService.telemetryLevel = TelemetryLevel.USAGE;
// } else {
// this.telemetryService.telemetryLevel = TelemetryLevel.NONE;
// }
throw "Telemetry level is readonly";
}
get isOptedIn(): boolean {
return this.telemetryService.telemetryLevel.value !== TelemetryLevel.NONE;
}
getTelemetryInfo(): Promise<ITelemetryInfo> {
return this.telemetryService.getTelemetryInfo();
}
/** /**
* Creates a View event that can be sent later. This is used to log that a particular page or item was seen. * Creates a View event that can be sent later. This is used to log that a particular page or item was seen.
* @param view The name of the page or item that was viewed * @param view The name of the page or item that was viewed
@@ -222,19 +205,6 @@ export class NullAdsTelemetryService implements IAdsTelemetryService {
_serviceBrand: undefined; _serviceBrand: undefined;
get isOptedIn(): boolean {
return false;
}
setEnabled(value: boolean): void { }
getTelemetryInfo(): Promise<ITelemetryInfo> {
return Promise.resolve({
sessionId: '',
machineId: '',
firstSessionDate: '',
msftInternal: false
});
}
createViewEvent(view: string): ITelemetryEvent { return new NullTelemetryEventImpl(); } createViewEvent(view: string): ITelemetryEvent { return new NullTelemetryEventImpl(); }
sendViewEvent(view: string): void { } sendViewEvent(view: string): void { }
createActionEvent(view: string, action: string, target?: string, source?: string, durationInMs?: number): ITelemetryEvent { return new NullTelemetryEventImpl(); } createActionEvent(view: string, action: string, target?: string, source?: string, durationInMs?: number): ITelemetryEvent { return new NullTelemetryEventImpl(); }

7
src/sql/platform/telemetry/common/telemetry.ts
View File

@@ -5,7 +5,6 @@
import * as azdata from 'azdata'; import * as azdata from 'azdata';
import { createDecorator } from 'vs/platform/instantiation/common/instantiation'; import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
import { ITelemetryInfo } from 'vs/platform/telemetry/common/telemetry';
export const IAdsTelemetryService = createDecorator<IAdsTelemetryService>('adsTelemetryService'); export const IAdsTelemetryService = createDecorator<IAdsTelemetryService>('adsTelemetryService');
@@ -59,12 +58,6 @@ export interface IAdsTelemetryService {
// ITelemetryService functions // ITelemetryService functions
_serviceBrand: undefined; _serviceBrand: undefined;
setEnabled(value: boolean): void;
getTelemetryInfo(): Promise<ITelemetryInfo>;
isOptedIn: boolean;
// Custom event functions // Custom event functions
createViewEvent(view: string): ITelemetryEvent; createViewEvent(view: string): ITelemetryEvent;
sendViewEvent(view: string): void; sendViewEvent(view: string): void;