From 294aa8129871edf2ebdae33c3a9763c149b44b72 Mon Sep 17 00:00:00 2001 From: Yurong He <43652751+YurongHe@users.noreply.github.com> Date: Fri, 8 Feb 2019 11:17:46 -0800 Subject: [PATCH] =?UTF-8?q?Added=20serverVersion=20to=20contextProvider=20?= =?UTF-8?q?key,=20so=20Sql=20server=20preview=20das=E2=80=A6=20(#3981)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Added serverVersion to contextProvider key, so Sql server preview dashboard tab could be filter by it. * User major version instead of serverVersion --- extensions/mssql/src/contextProvider.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/extensions/mssql/src/contextProvider.ts b/extensions/mssql/src/contextProvider.ts index 8a21f2c376..dec7eb9c40 100644 --- a/extensions/mssql/src/contextProvider.ts +++ b/extensions/mssql/src/contextProvider.ts @@ -16,7 +16,8 @@ export enum BuiltInCommands { export enum ContextKeys { ISCLOUD = 'mssql:iscloud', EDITIONID = 'mssql:engineedition', - ISCLUSTER = 'mssql:iscluster' + ISCLUSTER = 'mssql:iscluster', + SERVERMAJORVERSION = 'mssql:servermajorversion' } const isCloudEditions = [ @@ -40,6 +41,7 @@ export default class ContextProvider { let iscloud: boolean; let edition: number; let isCluster: boolean = false; + let serverMajorVersion: number; if (e.profile.providerName.toLowerCase() === 'mssql' && !types.isUndefinedOrNull(e.serverInfo) && !types.isUndefinedOrNull(e.serverInfo.engineEditionId)) { if (isCloudEditions.some(i => i === e.serverInfo.engineEditionId)) { iscloud = true; @@ -55,6 +57,7 @@ export default class ContextProvider { isCluster = isBigDataCluster; } } + serverMajorVersion = e.serverInfo.serverMajorVersion; } if (iscloud === true || iscloud === false) { @@ -68,6 +71,10 @@ export default class ContextProvider { if (!types.isUndefinedOrNull(isCluster)) { setCommandContext(ContextKeys.ISCLUSTER, isCluster); } + + if (!types.isUndefinedOrNull(serverMajorVersion)) { + setCommandContext(ContextKeys.SERVERMAJORVERSION, serverMajorVersion); + } } dispose(): void {