From 2a7483c036ad177ce7243bbe1ece105f76001b88 Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Wed, 8 Jul 2020 14:23:52 -0700 Subject: [PATCH] Fix error when calling getParent (#11252) --- extensions/notebook/src/book/bookTreeItem.ts | 4 ++-- extensions/notebook/src/book/bookTreeView.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/extensions/notebook/src/book/bookTreeItem.ts b/extensions/notebook/src/book/bookTreeItem.ts index 7971ad4dbe..0013ba6e0b 100644 --- a/extensions/notebook/src/book/bookTreeItem.ts +++ b/extensions/notebook/src/book/bookTreeItem.ts @@ -29,7 +29,7 @@ export interface BookTreeItemFormat { export class BookTreeItem extends vscode.TreeItem { private _sections: IJupyterBookSection[]; - private _uri: string; + private _uri: string | undefined; private _previousUri: string; private _nextUri: string; public command: vscode.Command; @@ -124,7 +124,7 @@ export class BookTreeItem extends vscode.TreeItem { return this.book.title; } - public get uri(): string { + public get uri(): string | undefined { return this._uri; } diff --git a/extensions/notebook/src/book/bookTreeView.ts b/extensions/notebook/src/book/bookTreeView.ts index 78ea7e382f..0c8d6c38f0 100644 --- a/extensions/notebook/src/book/bookTreeView.ts +++ b/extensions/notebook/src/book/bookTreeView.ts @@ -485,7 +485,7 @@ export class BookTreeViewProvider implements vscode.TreeDataProvider { - if (element) { + if (element?.uri) { let parentPath: string; parentPath = path.join(element.root, Content, element.uri.substring(0, element.uri.lastIndexOf(path.posix.sep))); if (parentPath === element.root) {