ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Sql-Assessment api info button (#13490)

Browse Source
This commit is contained in:
Vladimir Chernov
2020-11-20 20:53:34 +03:00
committed by GitHub
parent 749989cd0b
commit 2a81a0a70f
5 changed files with 68 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
extensions/sql-assessment/src/assessmentResultGrid.ts
View File

@@ -30,7 +30,6 @@ export class AssessmentResultGrid implements vscode.Disposable {
private asmtType!: AssessmentType;
private targetTypeIcon: { [targetType: number]: azdata.IconColumnCellValue };
private readonly checkIdColOrder = 5;
private readonly targetColOrder = 1;
private readonly messageColOrder = 3;
@@ -81,7 +80,6 @@ export class AssessmentResultGrid implements vscode.Disposable {
headerFilter: true
}).component();
this.toDispose.push(
this.table.onRowSelected(async () => {
if (this.table.selectedRows?.length !== 1) {
@@ -90,7 +88,6 @@ export class AssessmentResultGrid implements vscode.Disposable {
await this.showDetails(this.table.selectedRows[0]);
}));
this.rootContainer = view.modelBuilder.flexContainer()
.withItems([this.table], {
flex: '1 1 auto',
@@ -109,7 +106,6 @@ export class AssessmentResultGrid implements vscode.Disposable {
flex: '0 0 200px',
order: 2,
CSSStyles: {
'padding-bottom': '15px',
'visibility': 'hidden'
}
});
@@ -132,17 +128,21 @@ export class AssessmentResultGrid implements vscode.Disposable {
this.rootContainer.setItemLayout(this.table, {
flex: '1 1 auto',
CSSStyles: {
'height': '100%'
'height': '100%',
'border-bottom': '3px solid rgb(221, 221, 221)'
}
});
await this.table.updateProperties({
'height': '100%'
});
this.detailsPanel.updateCssStyles({
'visibility': 'hidden'
});
if (this.dataItems.length > 0) {
this.table.selectedRows = [0];
} else {
await this.detailsPanel.updateCssStyles({
'visibility': 'hidden'
});
}
}
// we need to filter out warnings and error results since we don't have an appropriate way of displaying such messages.
@@ -196,8 +196,6 @@ export class AssessmentResultGrid implements vscode.Disposable {
});
}
private createDetailsPanel(view: azdata.ModelView): azdata.FlexContainer {
const root = view.modelBuilder.flexContainer()
@@ -206,8 +204,7 @@ export class AssessmentResultGrid implements vscode.Disposable {
height: '200px',
}).withProperties({
CSSStyles: {
'padding': '20px',
'border-top': '3px solid rgb(221, 221, 221)'
'padding': '0px 10px'
}
}).component();
const cssNoMarginFloatLeft = { 'margin': '0px', 'float': 'left' };
@@ -285,6 +282,7 @@ export class AssessmentResultGrid implements vscode.Disposable {
return root;
}
private clearOutDefaultRuleset(tags: string[]): string[] {
let idx = tags.findIndex(item => item.toUpperCase() === 'DEFAULTRULESET');
if (idx > -1) {