mirror of
https://github.com/ckaczor/azuredatastudio.git
synced 2026-01-31 01:25:38 -05:00
- Fixes #4129 Overlapping command help windows in notebook - Do not show parameter hints for inactive cells, to avoid them hanging around when no longer selected - Fixes #4116 Notebooks: Intellisense Doesn't Work using Add New Connection - Move connect/disconnect logic to 1 place (code component) instead of 2 - Handle the case where you connect after choosing active cell. We now hook to the event and update connection - Fix issues in sql session manager where result outputs 0 rows. This was failing to show the empty resultset contents, which is a regression vs. query editor. It also put unhandled error on the debug console - Fix #3913 Notebook: words selected in other cells should be unselected on cell change Note: after fix, now looks as follows. Need to do follow up to get correct grid min height 
This commit is contained in:
@@ -134,7 +134,6 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
|
||||
}
|
||||
|
||||
ngOnDestroy() {
|
||||
this.disconnect();
|
||||
this.dispose();
|
||||
if (this.notebookService) {
|
||||
this.notebookService.removeNotebookEditor(this);
|
||||
@@ -168,7 +167,6 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
|
||||
}
|
||||
if (cell !== this.model.activeCell) {
|
||||
if (this.model.activeCell) {
|
||||
this.disconnect();
|
||||
this.model.activeCell.active = false;
|
||||
}
|
||||
this._model.activeCell = cell;
|
||||
@@ -177,14 +175,6 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe
|
||||
}
|
||||
}
|
||||
|
||||
private disconnect() {
|
||||
if (this._model.defaultKernel.display_name === notebookConstants.SQL) {
|
||||
if (this._model.activeCell && this._model.activeCell.cellType === CellTypes.Code && this._model.activeCell.cellUri) {
|
||||
this.connectionManagementService.disconnect(this._model.activeCell.cellUri.toString()).catch(e => console.log(e));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
public unselectActiveCell() {
|
||||
if (this.model && this.model.activeCell) {
|
||||
this.model.activeCell.active = false;
|
||||
|
||||
Reference in New Issue
Block a user