ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-17 02:51:36 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix Notebook Tokenization Warnings (#9725)

Browse Source 
* Change html table serialization to array

* PR feedback

* rename variable
This commit is contained in:
Chris LaFreniere
2020-03-26 13:03:51 -07:00
committed by GitHub
parent dd132a25e7
commit 2c05b07ee4
1 changed files with 17 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/sql/workbench/services/notebook/browser/sql/sqlSessionManager.ts
View File

@@ -579,24 +579,30 @@ export class SQLFuture extends Disposable implements FutureInternal {
}; };
} }
private convertToHtmlTable(columns: IDbColumn[], d: QueryExecuteSubsetResult): string { private convertToHtmlTable(columns: IDbColumn[], d: QueryExecuteSubsetResult): string[] {
let htmlString = '<table>'; // Adding 3 for <table>, column title rows, </table>
let htmlStringArr: string[] = new Array(d.resultSubset.rowCount + 3);
htmlStringArr[0] = '<table>';
if (columns.length > 0) { if (columns.length > 0) {
htmlString += '<tr>'; let columnHeaders = '<tr>';
for (let column of columns) { for (let column of columns) {
htmlString += '<th>' + escape(column.columnName) + '</th>'; columnHeaders += `<th>${escape(column.columnName)}</th>`;
} }
htmlString += '</tr>'; columnHeaders += '</tr>';
htmlStringArr[1] = columnHeaders;
} }
let i = 2;
for (const row of d.resultSubset.rows) { for (const row of d.resultSubset.rows) {
htmlString += '<tr>'; let rowData = '<tr>';
for (let i = 0; i < columns.length; i++) { for (let columnIndex = 0; columnIndex < columns.length; columnIndex++) {
htmlString += '<td>' + escape(row[i].displayValue) + '</td>'; rowData += `<td>${escape(row[columnIndex].displayValue)}</td>`;
} }
htmlString += '</tr>'; rowData += '</tr>';
htmlStringArr[i] = rowData;
i++;
} }
htmlString += '</table>'; htmlStringArr[htmlStringArr.length - 1] = '</table>';
return htmlString; return htmlStringArr;
} }
private convertToDisplayMessage(msg: IResultMessage | string): nb.IIOPubMessage { private convertToDisplayMessage(msg: IResultMessage | string): nb.IIOPubMessage {