ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Have same connection logic for all nb int tests (#13844)

Browse Source
This commit is contained in:
Chris LaFreniere
2020-12-17 15:38:41 -08:00
committed by GitHub
parent 9aaa78e020
commit 2d6074706a
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/integration-tests/setEnvironmentVariables.js
View File

@@ -57,7 +57,7 @@ if (!LAUNCH_OPTION) {
* Below are the environment variable values that are not saved in AKV and might vary by machine * Below are the environment variable values that are not saved in AKV and might vary by machine
*/ */
// Pyton for Notebooks // Python for Notebooks
// This environment variable is required by notebook tests. // This environment variable is required by notebook tests.
// How to install it: // How to install it:
// Open ADS and run command 'Configure Python for Notebooks' command and install it to the default folder, // Open ADS and run command 'Configure Python for Notebooks' command and install it to the default folder,
@@ -73,7 +73,7 @@ const NOTEBOOK_PYTHON_INSTALL_PATH = path.join(os.homedir(), 'azuredatastudio-py
// Environment variable value validation // Environment variable value validation
if (!fs.existsSync(NOTEBOOK_PYTHON_INSTALL_PATH)) { if (!fs.existsSync(NOTEBOOK_PYTHON_INSTALL_PATH)) {
const message = 'the specified Pyton install path does not exist.' const message = 'the specified Python install path does not exist.'
+ os.EOL + os.EOL
+ 'if you have installed it, please update the NOTEBOOK_PYTHON_INSTALL_PATH variable in this script,' + 'if you have installed it, please update the NOTEBOOK_PYTHON_INSTALL_PATH variable in this script,'
+ os.EOL + os.EOL

2
extensions/integration-tests/src/test/notebook.test.ts
View File

@@ -39,7 +39,7 @@ suite('Notebook integration test suite', function () {
}); });
test('Sql NB test @UNSTABLE@', async function () { test('Sql NB test @UNSTABLE@', async function () {
let notebook = await openNotebook(sqlNotebookContent, sqlKernelMetadata, this.test.title + this.invocationCount++, true); let notebook = await openNotebook(sqlNotebookContent, sqlKernelMetadata, this.test.title + this.invocationCount++);
await runCell(notebook); await runCell(notebook);
const expectedOutput0 = '(1 row affected)'; const expectedOutput0 = '(1 row affected)';
let cellOutputs = notebook.document.cells[0].contents.outputs; let cellOutputs = notebook.document.cells[0].contents.outputs;