ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-23 17:23:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding error message and placeholder for dropdown (#17012)

Browse Source 
* Adding error message and placeholder for dropdown

* Fixing default error message for empty required dropdown

* Fixing a small input value updating bug

* Fixed a commend

* Fixed a comment

* PR fixes

* Using codicon

* Fixed screen reader not reading error message

* Adding support for multiple dropdowns error message

* Adding error border

* Fixing error border styling.

* Added more specific classes for styling

* Making styling more specific
This commit is contained in:
Aasim Khan
2021-09-10 13:40:25 -07:00
committed by GitHub
parent 3f0f977f3e
commit 2d609c9cbc
5 changed files with 134 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/sql/base/parts/editableDropdown/browser/dropdown.ts
View File

@@ -344,8 +344,8 @@ export class Dropdown extends Disposable implements IListVirtualDelegate<string>
}
public set value(val: string) {
this._input.value = val;
if (this._previousValue !== val) {
this._input.value = val;
this._previousValue = val;
this._onValueChange.fire(val);
}