diff --git a/extensions/theme-defaults/fileicons/images/Document_16x.svg b/extensions/theme-defaults/fileicons/images/Document_16x.svg
deleted file mode 100644
index 46a9f38cc8..0000000000
--- a/extensions/theme-defaults/fileicons/images/Document_16x.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/Document_16x_inverse.svg b/extensions/theme-defaults/fileicons/images/Document_16x_inverse.svg
deleted file mode 100644
index 14abfb5107..0000000000
--- a/extensions/theme-defaults/fileicons/images/Document_16x_inverse.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/FolderOpen_16x.svg b/extensions/theme-defaults/fileicons/images/FolderOpen_16x.svg
deleted file mode 100644
index 1a3933d635..0000000000
--- a/extensions/theme-defaults/fileicons/images/FolderOpen_16x.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/FolderOpen_16x_inverse.svg b/extensions/theme-defaults/fileicons/images/FolderOpen_16x_inverse.svg
deleted file mode 100644
index fbf57c927f..0000000000
--- a/extensions/theme-defaults/fileicons/images/FolderOpen_16x_inverse.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/Folder_16x.svg b/extensions/theme-defaults/fileicons/images/Folder_16x.svg
deleted file mode 100644
index 3d64ae71db..0000000000
--- a/extensions/theme-defaults/fileicons/images/Folder_16x.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/Folder_16x_inverse.svg b/extensions/theme-defaults/fileicons/images/Folder_16x_inverse.svg
deleted file mode 100644
index 13b18d1801..0000000000
--- a/extensions/theme-defaults/fileicons/images/Folder_16x_inverse.svg
+++ /dev/null
@@ -1 +0,0 @@
-
\ No newline at end of file
diff --git a/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x.svg b/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x.svg
deleted file mode 100644
index 20460ec997..0000000000
--- a/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x.svg
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x_inverse.svg b/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x_inverse.svg
deleted file mode 100644
index d1a0fb04b7..0000000000
--- a/extensions/theme-defaults/fileicons/images/RootFolderOpen_16x_inverse.svg
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/extensions/theme-defaults/fileicons/images/RootFolder_16x.svg b/extensions/theme-defaults/fileicons/images/RootFolder_16x.svg
deleted file mode 100644
index 9a049f6237..0000000000
--- a/extensions/theme-defaults/fileicons/images/RootFolder_16x.svg
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/extensions/theme-defaults/fileicons/images/RootFolder_16x_inverse.svg b/extensions/theme-defaults/fileicons/images/RootFolder_16x_inverse.svg
deleted file mode 100644
index 0372127294..0000000000
--- a/extensions/theme-defaults/fileicons/images/RootFolder_16x_inverse.svg
+++ /dev/null
@@ -1 +0,0 @@
-
diff --git a/extensions/theme-defaults/fileicons/images/document-dark.svg b/extensions/theme-defaults/fileicons/images/document-dark.svg
new file mode 100644
index 0000000000..5ed5762a1f
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/document-dark.svg
@@ -0,0 +1,3 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/document-light.svg b/extensions/theme-defaults/fileicons/images/document-light.svg
new file mode 100644
index 0000000000..ad54e13b1b
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/document-light.svg
@@ -0,0 +1,3 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/folder-dark.svg b/extensions/theme-defaults/fileicons/images/folder-dark.svg
new file mode 100644
index 0000000000..43d454e7e5
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/folder-dark.svg
@@ -0,0 +1,3 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/folder-light.svg b/extensions/theme-defaults/fileicons/images/folder-light.svg
new file mode 100644
index 0000000000..8daecdac6a
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/folder-light.svg
@@ -0,0 +1,3 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/folder-open-dark.svg b/extensions/theme-defaults/fileicons/images/folder-open-dark.svg
new file mode 100644
index 0000000000..6bc1c584e4
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/folder-open-dark.svg
@@ -0,0 +1,4 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/folder-open-light.svg b/extensions/theme-defaults/fileicons/images/folder-open-light.svg
new file mode 100644
index 0000000000..0a50339b6c
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/folder-open-light.svg
@@ -0,0 +1,4 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/root-folder-dark.svg b/extensions/theme-defaults/fileicons/images/root-folder-dark.svg
new file mode 100644
index 0000000000..cdb770c86a
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/root-folder-dark.svg
@@ -0,0 +1,5 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/root-folder-light.svg b/extensions/theme-defaults/fileicons/images/root-folder-light.svg
new file mode 100644
index 0000000000..82a0294696
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/root-folder-light.svg
@@ -0,0 +1,5 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/root-folder-open-dark.svg b/extensions/theme-defaults/fileicons/images/root-folder-open-dark.svg
new file mode 100644
index 0000000000..472def3daa
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/root-folder-open-dark.svg
@@ -0,0 +1,5 @@
+
diff --git a/extensions/theme-defaults/fileicons/images/root-folder-open-light.svg b/extensions/theme-defaults/fileicons/images/root-folder-open-light.svg
new file mode 100644
index 0000000000..d2363bfae3
--- /dev/null
+++ b/extensions/theme-defaults/fileicons/images/root-folder-open-light.svg
@@ -0,0 +1,5 @@
+
diff --git a/extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json b/extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json
index be2fa29324..e2c2930017 100644
--- a/extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json
+++ b/extensions/theme-defaults/fileicons/vs_minimal-icon-theme.json
@@ -1,34 +1,34 @@
{
"iconDefinitions": {
"_root_folder_dark": {
- "iconPath": "./images/RootFolder_16x_inverse.svg"
+ "iconPath": "./images/root-folder-dark.svg"
},
"_root_folder_open_dark": {
- "iconPath": "./images/RootFolderOpen_16x_inverse.svg"
+ "iconPath": "./images/root-folder-open-dark.svg"
},
"_folder_dark": {
- "iconPath": "./images/Folder_16x_inverse.svg"
+ "iconPath": "./images/folder-dark.svg"
},
"_folder_open_dark": {
- "iconPath": "./images/FolderOpen_16x_inverse.svg"
+ "iconPath": "./images/folder-open-dark.svg"
},
"_file_dark": {
- "iconPath": "./images/Document_16x_inverse.svg"
+ "iconPath": "./images/document-dark.svg"
},
"_root_folder": {
- "iconPath": "./images/RootFolder_16x.svg"
+ "iconPath": "./images/root-folder-light.svg"
},
"_root_folder_open": {
- "iconPath": "./images/RootFolderOpen_16x.svg"
+ "iconPath": "./images/root-folder-open-light.svg"
},
"_folder_light": {
- "iconPath": "./images/Folder_16x.svg"
+ "iconPath": "./images/folder-light.svg"
},
"_folder_open_light": {
- "iconPath": "./images/FolderOpen_16x.svg"
+ "iconPath": "./images/folder-open-light.svg"
},
"_file_light": {
- "iconPath": "./images/Document_16x.svg"
+ "iconPath": "./images/document-light.svg"
},
"notebook": {
"iconPath": "./images/notebook.svg"
@@ -37,7 +37,6 @@
"iconPath": "./images/notebook_inverse.svg"
}
},
-
"folderExpanded": "_folder_open_dark",
"folder": "_folder_dark",
"file": "_file_dark",
@@ -75,4 +74,4 @@
"highContrast": {
// overrides for high contrast
}
-}
\ No newline at end of file
+}
diff --git a/package.json b/package.json
index 65b7d98ef3..3849272d10 100644
--- a/package.json
+++ b/package.json
@@ -137,7 +137,11 @@
"husky": "^0.13.1",
"innosetup": "5.6.1",
"is": "^3.1.0",
- "istanbul": "^0.3.17",
+ "istanbul-lib-coverage": "^2.0.5",
+ "istanbul-lib-instrument": "^3.3.0",
+ "istanbul-lib-report": "^2.0.8",
+ "istanbul-lib-source-maps": "^3.0.6",
+ "istanbul-reports": "^2.2.6",
"jsdom-no-contextify": "^3.1.0",
"lazy.js": "^0.4.2",
"merge-options": "^1.0.1",
@@ -152,7 +156,6 @@
"pump": "^1.0.1",
"queue": "3.0.6",
"rcedit": "^1.1.0",
- "remap-istanbul": "^0.13.0",
"rimraf": "^2.2.8",
"should": "^13.2.3",
"sinon": "^1.17.2",
@@ -189,4 +192,4 @@
"windows-mutex": "0.2.1",
"windows-process-tree": "0.2.4"
}
-}
\ No newline at end of file
+}
diff --git a/resources/win32/bin/code.sh b/resources/win32/bin/code.sh
index d4d3f2220c..23a4001a47 100644
--- a/resources/win32/bin/code.sh
+++ b/resources/win32/bin/code.sh
@@ -1,4 +1,4 @@
-#!/usr/bin/env bash
+#!/usr/bin/env sh
#
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the Source EULA. See License.txt in the project root for license information.
@@ -11,7 +11,7 @@ VSCODE_PATH="$(dirname "$(dirname "$(realpath "$0")")")"
ELECTRON="$VSCODE_PATH/$NAME.exe"
if grep -qi Microsoft /proc/version; then
# in a wsl shell
- if ! [ -z "$WSL_DISTRO_NAME" ]; then
+ if [ "$WSL_DISTRO_NAME" ]; then
# $WSL_DISTRO_NAME is available since WSL builds 18362, also for WSL2
WSL_BUILD=18362
else
@@ -26,21 +26,16 @@ if grep -qi Microsoft /proc/version; then
# WSLPATH is available since WSL build 17046
# WSLENV is available since WSL build 17063
export WSLENV=ELECTRON_RUN_AS_NODE/w:$WSLENV
+ CLI=$(wslpath -m "$VSCODE_PATH/resources/app/out/cli.js")
# use the Remote WSL extension if installed
- pushd "$VSCODE_PATH" > /dev/null
WSL_EXT_ID="ms-vscode-remote.remote-wsl"
- WSL_EXT_WLOC=$(ELECTRON_RUN_AS_NODE=1 "$ELECTRON" ".\resources\app\out\cli.js" --locate-extension $WSL_EXT_ID)
- popd > /dev/null
-
- if ! [ -z "$WSL_EXT_WLOC" ]; then
+ WSL_EXT_WLOC=$(ELECTRON_RUN_AS_NODE=1 "$ELECTRON" "$CLI" --locate-extension $WSL_EXT_ID)
+ if [ -n "$WSL_EXT_WLOC" ]; then
# replace \r\n with \n in WSL_EXT_WLOC
WSL_CODE=$(wslpath -u "${WSL_EXT_WLOC%%[[:cntrl:]]}")/scripts/wslCode.sh
- WIN_CODE_CMD=$(wslpath -w "$VSCODE_PATH/bin/$APP_NAME.cmd")
- "$WSL_CODE" "$COMMIT" "$QUALITY" "$WIN_CODE_CMD" "$APP_NAME" "$DATAFOLDER" "$@"
+ "$WSL_CODE" "$COMMIT" "$QUALITY" "$ELECTRON" "$APP_NAME" "$DATAFOLDER" "$@"
exit $?
- else
- CLI=$(wslpath -m "$VSCODE_PATH/resources/app/out/cli.js")
fi
else
# If running under older WSL, don't pass cli.js to Electron as
diff --git a/src/vs/base/browser/ui/centered/centeredViewLayout.ts b/src/vs/base/browser/ui/centered/centeredViewLayout.ts
index e0fb0490dc..e25e31fafd 100644
--- a/src/vs/base/browser/ui/centered/centeredViewLayout.ts
+++ b/src/vs/base/browser/ui/centered/centeredViewLayout.ts
@@ -6,7 +6,7 @@
import { SplitView, Orientation, ISplitViewStyles, IView as ISplitViewView } from 'vs/base/browser/ui/splitview/splitview';
import { $ } from 'vs/base/browser/dom';
import { Event } from 'vs/base/common/event';
-import { IView } from 'vs/base/browser/ui/grid/gridview';
+import { IView, IViewSize } from 'vs/base/browser/ui/grid/gridview';
import { IDisposable, DisposableStore } from 'vs/base/common/lifecycle';
import { Color } from 'vs/base/common/color';
@@ -68,6 +68,7 @@ export class CenteredViewLayout implements IDisposable {
get maximumWidth(): number { return this.splitView ? this.splitView.maximumSize : this.view.maximumWidth; }
get minimumHeight(): number { return this.view.minimumHeight; }
get maximumHeight(): number { return this.view.maximumHeight; }
+ get onDidChange(): Event { return this.view.onDidChange; }
layout(width: number, height: number): void {
this.width = width;
diff --git a/src/vs/base/browser/ui/grid/grid.ts b/src/vs/base/browser/ui/grid/grid.ts
index 6bd266b3a7..2d5eb702ba 100644
--- a/src/vs/base/browser/ui/grid/grid.ts
+++ b/src/vs/base/browser/ui/grid/grid.ts
@@ -300,12 +300,6 @@ export class Grid extends Disposable {
return this.gridview.getViewSize(location);
}
- // TODO@joao cleanup
- getViewSize2(view: T): { width: number; height: number; } {
- const location = this.getViewLocation(view);
- return this.gridview.getViewSize(location);
- }
-
maximizeViewSize(view: T): void {
const location = this.getViewLocation(view);
this.gridview.maximizeViewSize(location);
diff --git a/src/vs/base/browser/ui/list/list.css b/src/vs/base/browser/ui/list/list.css
index 24111a0134..b2cbdd591b 100644
--- a/src/vs/base/browser/ui/list/list.css
+++ b/src/vs/base/browser/ui/list/list.css
@@ -126,13 +126,13 @@
-webkit-appearance: none;
width: 16px;
height: 16px;
- background: url("media/no-filter.svg");
+ background: url("media/no-filter-light.svg");
background-position: 50% 50%;
cursor: pointer;
}
.monaco-list-type-filter > .controls > .filter:checked {
- background-image: url("media/filter.svg");
+ background-image: url("media/filter-light.svg");
}
.vs-dark .monaco-list-type-filter > .controls > .filter {
@@ -153,7 +153,7 @@
.monaco-list-type-filter > .controls > .clear {
border: none;
- background: url("media/close.svg");
+ background: url("media/close-light.svg");
cursor: pointer;
}
diff --git a/src/vs/base/browser/ui/list/media/close-dark.svg b/src/vs/base/browser/ui/list/media/close-dark.svg
index 751e89b3b0..7305a8f099 100644
--- a/src/vs/base/browser/ui/list/media/close-dark.svg
+++ b/src/vs/base/browser/ui/list/media/close-dark.svg
@@ -1 +1,3 @@
-
\ No newline at end of file
+
diff --git a/src/vs/base/browser/ui/list/media/close-hc.svg b/src/vs/base/browser/ui/list/media/close-hc.svg
index c20895c60a..7305a8f099 100644
--- a/src/vs/base/browser/ui/list/media/close-hc.svg
+++ b/src/vs/base/browser/ui/list/media/close-hc.svg
@@ -1,33 +1,3 @@
-
-