Remove preview flag for table designer (#20720)

* remove the preview flag for table designer feature

* sqlproj
This commit is contained in:
Alan Ren
2022-10-04 10:58:44 -07:00
committed by GitHub
parent 102888b964
commit 2df3f1a161
3 changed files with 5 additions and 8 deletions

View File

@@ -539,24 +539,24 @@
}, },
{ {
"command": "mssql.designTable", "command": "mssql.designTable",
"when": "connectionProvider == MSSQL && nodeType == Table && nodeSubType != LedgerDropped && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Table && nodeSubType != LedgerDropped",
"group": "0_query@3" "group": "0_query@3"
}, },
{ {
"command": "mssql.newTable", "command": "mssql.newTable",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Tables && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Tables",
"group": "0_query@1" "group": "0_query@1"
} }
], ],
"dataExplorer/context": [ "dataExplorer/context": [
{ {
"command": "mssql.designTable", "command": "mssql.designTable",
"when": "connectionProvider == MSSQL && nodeType == Table && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Table",
"group": "connection@3" "group": "connection@3"
}, },
{ {
"command": "mssql.newTable", "command": "mssql.newTable",
"when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Tables && config.workbench.enablePreviewFeatures", "when": "connectionProvider == MSSQL && nodeType == Folder && objectType == Tables",
"group": "connection@1" "group": "connection@1"
} }
], ],

View File

@@ -407,7 +407,7 @@
}, },
{ {
"command": "sqlDatabaseProjects.openInDesigner", "command": "sqlDatabaseProjects.openInDesigner",
"when": "azdataAvailable && view == dataworkspace.views.main && viewItem == databaseProject.itemType.file.table && config.workbench.enablePreviewFeatures", "when": "azdataAvailable && view == dataworkspace.views.main && viewItem == databaseProject.itemType.file.table",
"group": "6_dbProjects_openInDesigner" "group": "6_dbProjects_openInDesigner"
}, },
{ {

View File

@@ -20,7 +20,6 @@ import { SaveTableChangesAction } from 'sql/workbench/contrib/tableDesigner/brow
import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation'; import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { IColorTheme, ICssStyleCollector, registerThemingParticipant } from 'vs/platform/theme/common/themeService'; import { IColorTheme, ICssStyleCollector, registerThemingParticipant } from 'vs/platform/theme/common/themeService';
import { DesignerPaneSeparator } from 'sql/platform/theme/common/colorRegistry'; import { DesignerPaneSeparator } from 'sql/platform/theme/common/colorRegistry';
import { localize } from 'vs/nls';
export class TableDesignerEditor extends EditorPane { export class TableDesignerEditor extends EditorPane {
public static readonly ID: string = 'workbench.editor.tableDesigner'; public static readonly ID: string = 'workbench.editor.tableDesigner';
@@ -53,8 +52,6 @@ export class TableDesignerEditor extends EditorPane {
const container = parent.appendChild(DOM.$('.table-designer-main-container')); const container = parent.appendChild(DOM.$('.table-designer-main-container'));
const topRowContainer = container.appendChild(DOM.$('.top-row-container')); const topRowContainer = container.appendChild(DOM.$('.top-row-container'));
const actionbarContainer = topRowContainer.appendChild(DOM.$('.actionbar-container')); const actionbarContainer = topRowContainer.appendChild(DOM.$('.actionbar-container'));
const previewFlag = topRowContainer.appendChild(DOM.$('.preview-flag-container.codicon.info'));
previewFlag.innerText = localize('tableDesigner.PreviewFeature', "Preview feature");
const designerContainer = container.appendChild(DOM.$('.designer-container')); const designerContainer = container.appendChild(DOM.$('.designer-container'));
const actionbar = new ActionBar(actionbarContainer); const actionbar = new ActionBar(actionbarContainer);
this._register(actionbar); this._register(actionbar);