From 2eab870ca2d87fbb2e4f4d4e6678ca877d2bf80d Mon Sep 17 00:00:00 2001 From: Hai Cao Date: Fri, 18 Jun 2021 13:34:59 -0700 Subject: [PATCH] remove "Edit Data" menu option for SqlDataWarehouse (#15816) --- .../browser/scripting.contribution.ts | 23 ++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/src/sql/workbench/contrib/scripting/browser/scripting.contribution.ts b/src/sql/workbench/contrib/scripting/browser/scripting.contribution.ts index 60f8b2b4dd..bbc5483f7e 100644 --- a/src/sql/workbench/contrib/scripting/browser/scripting.contribution.ts +++ b/src/sql/workbench/contrib/scripting/browser/scripting.contribution.ts @@ -81,7 +81,12 @@ MenuRegistry.appendMenuItem(MenuId.DataExplorerContext, { id: commands.EDIT_DATA_COMMAND_ID, title: localize('editData', "Edit Data") }, - when: ContextKeyExpr.and(MssqlNodeContext.CanEditData, MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString())) + when: + ContextKeyExpr.and( + MssqlNodeContext.CanEditData, + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString()), + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlDataWarehouse.toString()) + ) }); //#endregion @@ -123,7 +128,13 @@ MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, { id: commands.OE_EDIT_DATA_COMMAND_ID, title: localize('editData', "Edit Data") }, - when: ContextKeyExpr.and(TreeNodeContextKey.NodeType.isEqualTo('Table'), ConnectionContextKey.Provider.notEqualsTo('KUSTO'), MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString())) + when: + ContextKeyExpr.and( + TreeNodeContextKey.NodeType.isEqualTo('Table'), + ConnectionContextKey.Provider.notEqualsTo('KUSTO'), + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString()), + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlDataWarehouse.toString()) + ) }); MenuRegistry.appendMenuItem(MenuId.ObjectExplorerItemContext, { @@ -291,7 +302,13 @@ MenuRegistry.appendMenuItem(MenuId.ExplorerWidgetContext, { id: ExplorerEditDataActionID, title: EditDataAction.LABEL }, - when: ContextKeyExpr.and(ItemContextKey.ItemType.isEqualTo('table'), MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString()), ItemContextKey.ConnectionProvider.notEqualsTo('kusto')), + when: + ContextKeyExpr.and( + ItemContextKey.ItemType.isEqualTo('table'), + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlOnDemand.toString()), + ItemContextKey.ConnectionProvider.notEqualsTo('kusto'), + MssqlNodeContext.EngineEdition.notEqualsTo(DatabaseEngineEdition.SqlDataWarehouse.toString()) + ), order: 2 });