ADS changes for opening XEL files (#23666)

* Initial set of changes for opening XEL files in ADS

* Code cleanup and update STS version

* Fix runtime errors

* Address comments

* Address comments and update Start button to be disabled for file session

* Code cleanup
This commit is contained in:
Sakshi Sharma
2023-07-09 10:22:12 -07:00
committed by GitHub
parent 3f19d0026e
commit 2fd2b79611
16 changed files with 136 additions and 27 deletions

View File

@@ -1298,9 +1298,14 @@ export interface StartProfilingParams {
ownerUri: string;
/**
* Session name
* Session name or full path of XEL file to open
*/
sessionName: string;
/**
* Identifies which type of target session name identifies
*/
sessionType: azdata.ProfilingSessionType;
}
export interface StartProfilingResponse { }

View File

@@ -1001,10 +1001,11 @@ export class ProfilerFeature extends SqlOpsFeature<undefined> {
);
};
let startSession = (ownerUri: string, sessionName: string): Thenable<boolean> => {
let startSession = (ownerUri: string, sessionName: string, sessionType: azdata.ProfilingSessionType = azdata.ProfilingSessionType.RemoteSession): Thenable<boolean> => {
let params: contracts.StartProfilingParams = {
ownerUri,
sessionName
sessionName,
sessionType
};
return client.sendRequest(contracts.StartProfilingRequest.type, params).then(

View File

@@ -51,6 +51,11 @@
"command": "profiler.openCreateSessionDialog",
"title": "profiler.contributes.title.openCreateSessionDialog",
"category": "%profiler.category%"
},
{
"command": "profiler.openFile",
"title": "%profiler.contributes.title.openXELFile%",
"category": "%profiler.category%"
}
],
"menus": {

View File

@@ -5,5 +5,6 @@
"profiler.contributes.title.start": "Start",
"profiler.contributes.title.stop": "Stop",
"profiler.contributes.title.openCreateSessionDialog": "Create Profiler Season",
"profiler.category": "Profiler"
"profiler.category": "Profiler",
"profiler.contributes.title.openXELFile": "Open XEL File"
}