ADS changes for opening XEL files (#23666)

* Initial set of changes for opening XEL files in ADS

* Code cleanup and update STS version

* Fix runtime errors

* Address comments

* Address comments and update Start button to be disabled for file session

* Code cleanup
This commit is contained in:
Sakshi Sharma
2023-07-09 10:22:12 -07:00
committed by GitHub
parent 3f19d0026e
commit 2fd2b79611
16 changed files with 136 additions and 27 deletions

View File

@@ -359,8 +359,8 @@ export class MainThreadDataProtocol extends Disposable implements MainThreadData
createSession(sessionId: string, createStatement: string, template: azdata.ProfilerSessionTemplate): Thenable<boolean> {
return self._proxy.$createSession(handle, sessionId, createStatement, template);
},
startSession(sessionId: string, sessionName: string): Thenable<boolean> {
return self._proxy.$startSession(handle, sessionId, sessionName);
startSession(sessionId: string, sessionName: string, sessionType?: azdata.ProfilingSessionType): Thenable<boolean> {
return self._proxy.$startSession(handle, sessionId, sessionName, sessionType);
},
stopSession(sessionId: string): Thenable<boolean> {
return self._proxy.$stopSession(handle, sessionId);

View File

@@ -686,8 +686,8 @@ export class ExtHostDataProtocol extends ExtHostDataProtocolShape {
/**
* Start a profiler session
*/
public override $startSession(handle: number, sessionId: string, sessionName: string): Thenable<boolean> {
return this._resolveProvider<azdata.ProfilerProvider>(handle).startSession(sessionId, sessionName);
public override $startSession(handle: number, sessionId: string, sessionName: string, sessionType?: azdata.ProfilingSessionType): Thenable<boolean> {
return this._resolveProvider<azdata.ProfilerProvider>(handle).startSession(sessionId, sessionName, sessionType);
}
/**
@@ -739,7 +739,6 @@ export class ExtHostDataProtocol extends ExtHostDataProtocolShape {
this._proxy.$onProfilerSessionCreated(handle, response);
}
/**
* Agent Job Provider methods
*/

View File

@@ -687,7 +687,8 @@ export function createAdsApiFactory(accessor: ServicesAccessor): IAdsExtensionAp
designers: designers,
executionPlan: executionPlan,
diagnostics: diagnostics,
env
env,
ProfilingSessionType: sqlExtHostTypes.ProfilingSessionType
};
}
};

View File

@@ -385,7 +385,7 @@ export abstract class ExtHostDataProtocolShape {
/**
* Start a profiler session
*/
$startSession(handle: number, sessionId: string, sessionName: string): Thenable<boolean> { throw ni(); }
$startSession(handle: number, sessionId: string, sessionName: string, sessionType?: azdata.ProfilingSessionType): Thenable<boolean> { throw ni(); }
/**
* Stop a profiler session

View File

@@ -219,6 +219,11 @@ export enum StepCompletionAction {
GoToStep = 4
}
export enum ProfilingSessionType {
RemoteSession = 0,
LocalFile = 1
}
export interface CheckBoxInfo {
row: number;
columnName: string;