Enable custom delimiters when saving as CSV (#1928)

* Support custom delimiters for csv

* Run tsfmt

src/sql/parts/query/common/query.contribution.ts

@@ -275,6 +275,11 @@ let registryProperties = {
 		'description': localize('sql.saveAsCsv.includeHeaders', '[Optional] When true, column headers are included when saving results as CSV'),
 		'default': true
 	},
+	'sql.saveAsCsv.delimiter': {
+		'type': 'string',
+		'description': localize('sql.saveAsCsv.delimiter', '[Optional] The custom delimiter to use between values when saving as CSV'),
+		'default': ','
+	},
 	'sql.copyIncludeHeaders': {
 		'type': 'boolean',
 		'description': localize('sql.copyIncludeHeaders', '[Optional] Configuration options for copying results from the Results View'),

src/sql/parts/query/common/resultSerializer.ts

@@ -186,7 +186,11 @@ export class ResultSerializer {
 			if (saveConfig.includeHeaders !== undefined) {
 				saveResultsParams.includeHeaders = saveConfig.includeHeaders;
 			}
+			if (saveConfig.delimiter !== undefined) {
+				saveResultsParams.delimiter = saveConfig.delimiter;
 			}
+		}
+
 		return saveResultsParams;
 	}
 
@@ -202,6 +206,7 @@ export class ResultSerializer {
 		// and we want to have just 1 setting that lists this.
 		let config = this.getConfigForCsv();
 		config.resultFormat = SaveFormat.EXCEL;
+		config.delimiter = undefined;
 		return config;
 	}
 

src/sql/sqlops.d.ts

@@ -840,6 +840,7 @@ declare module 'sqlops' {
 		columnStartIndex: number;
 		columnEndIndex: number;
 		includeHeaders?: boolean;
+		delimiter?: string;
 	}
 
 	export interface SaveResultRequestResult {
@@ -1395,8 +1396,7 @@ declare module 'sqlops' {
 		job: AgentJobInfo;
 	}
 
-	export interface AgentJobCategory
+	export interface AgentJobCategory {
-	{
 		id: string;
 		name: string;
 	}