diff --git a/extensions/arc/src/models/postgresModel.ts b/extensions/arc/src/models/postgresModel.ts index 8c6973dd11..7dbb13c63b 100644 --- a/extensions/arc/src/models/postgresModel.ts +++ b/extensions/arc/src/models/postgresModel.ts @@ -53,10 +53,7 @@ export class PostgresModel extends ResourceModel { /** Returns the major version of Postgres */ public get engineVersion(): string | undefined { - const kind = this._config?.kind; - return kind - ? kind.substring(kind.lastIndexOf('-') + 1) - : undefined; + return this._config?.spec.engine.version; } /** Returns the IP address and port of Postgres */ diff --git a/extensions/arc/src/test/mocks/fakeAzdataApi.ts b/extensions/arc/src/test/mocks/fakeAzdataApi.ts index e9c6a95aee..f3f78e630a 100644 --- a/extensions/arc/src/test/mocks/fakeAzdataApi.ts +++ b/extensions/arc/src/test/mocks/fakeAzdataApi.ts @@ -49,7 +49,6 @@ export class FakeAzdataApi implements azdataExt.IAzdataApi { replaceEngineSettings?: boolean, workers?: number }, - _engineVersion?: string, _additionalEnvVars?: azdataExt.AdditionalEnvVars ): Promise> { throw new Error('Method not implemented.'); } } diff --git a/extensions/arc/src/test/models/postgresModel.test.ts b/extensions/arc/src/test/models/postgresModel.test.ts index 2445026a1e..76adefcda8 100644 --- a/extensions/arc/src/test/models/postgresModel.test.ts +++ b/extensions/arc/src/test/models/postgresModel.test.ts @@ -41,7 +41,8 @@ export const FakePostgresServerShowOutput: azdataExt.AzdataOutput(argsArray, additionalEnvVars, session); } } diff --git a/extensions/azdata/src/typings/azdata-ext.d.ts b/extensions/azdata/src/typings/azdata-ext.d.ts index ff7b7b6ee7..23ed29510d 100644 --- a/extensions/azdata/src/typings/azdata-ext.d.ts +++ b/extensions/azdata/src/typings/azdata-ext.d.ts @@ -160,7 +160,7 @@ declare module 'azdata-ext' { export interface PostgresServerShowResult { apiVersion: string, // "arcdata.microsoft.com/v1alpha1" - kind: string, // "postgresql-12" + kind: string, // "postgresql" metadata: { creationTimestamp: string, // "2020-08-19T20:25:11Z" generation: number, // 1 @@ -177,7 +177,8 @@ declare module 'azdata-ext' { }[], settings: { default: { [key: string]: string } // { "max_connections": "101", "work_mem": "4MB" } - } + }, + version: string // "12" }, scale: { shards: number, // 1 (shards was renamed to workers, kept here for backwards compatibility) @@ -278,7 +279,6 @@ declare module 'azdata-ext' { replaceEngineSettings?: boolean, workers?: number }, - engineVersion?: string, additionalEnvVars?: AdditionalEnvVars, session?: AzdataSession ): Promise>