Cleanup telemetry keys (#14795)

* Add event for connection error

* Cleanup telemetry keys

* Fix missed keys
This commit is contained in:
Charles Gagnon
2021-03-18 15:52:57 -07:00
committed by GitHub
parent af19f93b78
commit 31ce58a8fc
28 changed files with 88 additions and 89 deletions

View File

@@ -42,7 +42,7 @@ export class BackupService implements IBackupService {
return new Promise<azdata.BackupResponse>((resolve, reject) => {
const providerResult = this.getProvider(connectionUri);
if (providerResult) {
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.BackupCreated)
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.TelemetryAction.BackupCreated)
.withAdditionalProperties({ providerId: providerResult.providerName })
.send();
providerResult.provider.backup(connectionUri, backupInfo, taskExecutionMode).then(result => {

View File

@@ -3,49 +3,24 @@
* Licensed under the Source EULA. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
// Telemetry Event Names
export const DatabaseConnected = 'DatabaseConnected';
export const DatabaseConnectionError = 'DatabaseConnectionError';
export const DatabaseDisconnected = 'DatabaseDisconnected';
export const DeleteConnection = 'DeleteConnection';
export const AddServerGroup = 'AddServerGroup';
export const MoveServerGroup = 'MoveServerGroup';
export const MoveServerConnection = 'MoveServerConnection';
export const DeleteServerGroup = 'DeleteServerGroup';
export const BackupCreated = 'BackupCreated';
export const RestoreRequested = 'RestoreRequested';
export const ChartCreated = 'ChartCreated';
export const ObjectExplorerExpand = 'ObjectExplorerExpand';
export const RunQuery = 'RunQuery';
export const RunQueryStatement = 'RunQueryStatement';
export const RunQueryString = 'RunQueryString';
export const CancelQuery = 'CancelQuery';
export const NewQuery = 'NewQuery';
export const FirewallRuleRequested = 'FirewallRuleCreated';
export const DashboardNavigated = 'DashboardNavigated';
export const GetDataGridItems = 'GetDataGridItems';
export const GetDataGridColumns = 'GetDataGridColumns';
// Telemetry Properties
// Modal Dialogs:
export const ErrorMessage = 'ErrorMessage';
export const WebView = 'WebView';
export const ConnectionAdvancedProperties = 'ConnectionAdvancedProperties';
export const Connection = 'Connection';
export const Backup = 'Backup';
export const Restore = 'Restore';
export const Insights = 'Insights';
export const Profiler = 'Profiler';
export const ServerGroups = 'ServerGroups';
export const Accounts = 'Accounts';
export const FireWallRule = 'FirewallRule';
export const AutoOAuth = 'AutoOAuth';
export const AddNewDashboardTab = 'AddNewDashboardTab';
export const ProfilerFilter = 'ProfilerFilter';
export const CalloutDialog = 'CalloutDialog';
export enum ModalDialogName {
ErrorMessage = 'ErrorMessage',
WebView = 'WebView',
ConnectionAdvancedProperties = 'ConnectionAdvancedProperties',
Connection = 'Connection',
Backup = 'Backup',
FileBrowser = 'FileBrowser',
Restore = 'Restore',
Insights = 'Insights',
Profiler = 'Profiler',
ServerGroups = 'ServerGroups',
Accounts = 'Accounts',
FireWallRule = 'FirewallRule',
AutoOAuth = 'AutoOAuth',
AddNewDashboardTab = 'AddNewDashboardTab',
ProfilerFilter = 'ProfilerFilter',
CalloutDialog = 'CalloutDialog'
}
export enum TelemetryView {
Agent = 'Agent',
@@ -61,20 +36,44 @@ export enum TelemetryView {
SqlAssessment = 'SqlAssessment'
}
export enum TelemetryError {
DatabaseConnectionError = 'DatabaseConnectionError'
}
export enum TelemetryAction {
AddServerGroup = 'AddServerGroup',
adsCommandExecuted = 'adsCommandExecuted',
Click = 'Click',
Open = 'Open',
ModelViewDashboardOpened = 'ModelViewDashboardOpened',
ModalDialogClosed = 'ModalDialogClosed',
ModalDialogOpened = 'ModalDialogOpened',
RunAgentJob = 'RunAgentJob',
StopAgentJob = 'StopAgentJob',
BackupCreated = 'BackupCreated',
DashboardNavigated = 'DashboardNavigated',
DatabaseConnected = 'DatabaseConnected',
DatabaseDisconnected = 'DatabaseDisconnected',
DeleteAgentJob = 'DeleteAgentJob',
DeleteAgentJobStep = 'DeleteAgentJobStep',
DeleteAgentAlert = 'DeleteAgentAlert',
DeleteAgentOperator = 'DeleteAgentOperator',
DeleteAgentProxy = 'DeleteAgentProxy',
DeleteConnection = 'DeleteConnection',
DeleteServerGroup = 'DeleteServerGroup',
CancelQuery = 'CancelQuery',
ChartCreated = 'ChartCreated',
Click = 'Click',
FirewallRuleRequested = 'FirewallRuleCreated',
GetDataGridItems = 'GetDataGridItems',
GetDataGridColumns = 'GetDataGridColumns',
ModelViewDashboardOpened = 'ModelViewDashboardOpened',
ModalDialogClosed = 'ModalDialogClosed',
ModalDialogOpened = 'ModalDialogOpened',
MoveServerConnection = 'MoveServerConnection',
MoveServerGroup = 'MoveServerGroup',
NewQuery = 'NewQuery',
ObjectExplorerExpand = 'ObjectExplorerExpand',
Open = 'Open',
RestoreRequested = 'RestoreRequested',
RunAgentJob = 'RunAgentJob',
RunQuery = 'RunQuery',
RunQueryStatement = 'RunQueryStatement',
RunQueryString = 'RunQueryString',
StopAgentJob = 'StopAgentJob',
WizardPagesNavigation = 'WizardPagesNavigation'
}