Cleanup telemetry keys (#14795)

* Add event for connection error

* Cleanup telemetry keys

* Fix missed keys
This commit is contained in:
Charles Gagnon
2021-03-18 15:52:57 -07:00
committed by GitHub
parent af19f93b78
commit 31ce58a8fc
28 changed files with 88 additions and 89 deletions

View File

@@ -37,7 +37,7 @@ export class BackupDialog extends Modal {
@ILogService logService: ILogService,
@ITextResourcePropertiesService textResourcePropertiesService: ITextResourcePropertiesService
) {
super('', TelemetryKeys.Backup, telemetryService, layoutService, clipboardService, themeService, logService, textResourcePropertiesService, contextKeyService, { isAngular: true, hasErrors: true });
super('', TelemetryKeys.ModalDialogName.Backup, telemetryService, layoutService, clipboardService, themeService, logService, textResourcePropertiesService, contextKeyService, { isAngular: true, hasErrors: true });
}
protected renderBody(container: HTMLElement) {

View File

@@ -175,7 +175,7 @@ export const DashboardModule = (params, selector: string, instantiationService:
this._router.events.subscribe(e => {
if (e instanceof NavigationEnd) {
this.navigations++;
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.DashboardNavigated)
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.TelemetryAction.DashboardNavigated)
.withAdditionalProperties({ numberOfNavigations: this.navigations })
.send();
}

View File

@@ -76,7 +76,7 @@ export abstract class ChartInsight extends Disposable implements IInsightsView {
this._hasError = true;
this._changeRef.detectChanges();
}
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.ChartCreated)
this._telemetryService.createActionEvent(TelemetryKeys.TelemetryView.Shell, TelemetryKeys.TelemetryAction.ChartCreated)
.withAdditionalProperties({ type: this.chartType })
.send();
}

View File

@@ -66,7 +66,7 @@ export class ImageCalloutDialog extends Modal {
) {
super(
title,
TelemetryKeys.CalloutDialog,
TelemetryKeys.ModalDialogName.CalloutDialog,
telemetryService,
layoutService,
clipboardService,

View File

@@ -56,7 +56,7 @@ export class LinkCalloutDialog extends Modal {
) {
super(
title,
TelemetryKeys.CalloutDialog,
TelemetryKeys.ModalDialogName.CalloutDialog,
telemetryService,
layoutService,
clipboardService,

View File

@@ -49,7 +49,7 @@ export class WebViewDialog extends Modal {
@IWebviewService private readonly webviewService: IWebviewService,
@ITextResourcePropertiesService textResourcePropertiesService: ITextResourcePropertiesService
) {
super('', TelemetryKeys.WebView, telemetryService, layoutService, clipboardService, themeService, logService, textResourcePropertiesService, contextKeyService, { dialogStyle: 'normal', hasTitleIcon: true });
super('', TelemetryKeys.ModalDialogName.WebView, telemetryService, layoutService, clipboardService, themeService, logService, textResourcePropertiesService, contextKeyService, { dialogStyle: 'normal', hasTitleIcon: true });
this._okLabel = localize('webViewDialog.ok', "OK");
this._closeLabel = localize('webViewDialog.close', "Close");
}