Fix regressions in web build (#15920)

* Update build for web issues * Fix remote\web package.json * Remove extension activate test * Add terminal entry point * Bump distro * Update docker files and pipelines * Add linux task * Update build pool * Correct image name * Update pipelines * Fix indention * Update sql-web-build.yml for Azure Pipelines Add new build variable * Update sql-web-build.yml for Azure Pipelines Revert previous commit * Disable sourcemaps upload * Remove compile step * Fix yaml typo * Fix dependson error * Update yaml * Add notebook parameters * Remove web from desktop builds * Add web createDrop script * Bump distro * Change execution mode on createDrop script * Code review feedback * Update CI hygiene cache key * Bump distro * Fix merge conflicts * Revert "Fix merge conflicts" This reverts commit 06f7a58b6e0a065520b7686e8469e4e7682e157a. * Bump distro to before smoke test update
2026-02-16 10:58:30 -05:00 · 2021-06-29 12:12:27 -07:00
parent 10ad6f7119
commit 31e9c21c06
41 changed files with 1101 additions and 405 deletions
--- a/build/azure-pipelines/common/createAsset.js
+++ b/build/azure-pipelines/common/createAsset.js
@@ -83,7 +83,7 @@ async function main() {
    console.log('Asset:', JSON.stringify(asset, null, '  '));
    const client = new cosmos_1.CosmosClient({ endpoint: process.env['AZURE_DOCUMENTDB_ENDPOINT'], key: process.env['AZURE_DOCUMENTDB_MASTERKEY'] });
    const scripts = client.database('builds').container(quality).scripts;
-    await retry_1.retry(() => scripts.storedProcedure('createAsset').execute('', [commit, asset, true]));
+    await (0, retry_1.retry)(() => scripts.storedProcedure('createAsset').execute('', [commit, asset, true]));
 }
 main().then(() => {
    console.log('Asset successfully created');
--- a/build/azure-pipelines/common/createBuild.js
+++ b/build/azure-pipelines/common/createBuild.js
@@ -40,7 +40,7 @@ async function main() {
    };
    const client = new cosmos_1.CosmosClient({ endpoint: process.env['AZURE_DOCUMENTDB_ENDPOINT'], key: process.env['AZURE_DOCUMENTDB_MASTERKEY'] });
    const scripts = client.database('builds').container(quality).scripts;
-    await retry_1.retry(() => scripts.storedProcedure('createBuild').execute('', [Object.assign(Object.assign({}, build), { _partitionKey: '' })]));
+    await (0, retry_1.retry)(() => scripts.storedProcedure('createBuild').execute('', [Object.assign(Object.assign({}, build), { _partitionKey: '' })]));
 }
 main().then(() => {
    console.log('Build successfully created');
--- a/build/azure-pipelines/common/publish-webview.js
+++ b/build/azure-pipelines/common/publish-webview.js
@@ -39,7 +39,7 @@ async function publish(commit, files) {
        .withFilter(new azure.ExponentialRetryPolicyFilter(20));
    await assertContainer(blobService, commit);
    for (const file of files) {
-        const blobName = path_1.basename(file);
+        const blobName = (0, path_1.basename)(file);
        const blobExists = await doesBlobExist(blobService, commit, blobName);
        if (blobExists) {
            console.log(`Blob ${commit}, ${blobName} already exists, not publishing again.`);
@@ -58,7 +58,7 @@ function main() {
    }
    const opts = minimist(process.argv.slice(2));
    const [directory] = opts._;
-    const files = fileNames.map(fileName => path_1.join(directory, fileName));
+    const files = fileNames.map(fileName => (0, path_1.join)(directory, fileName));
    publish(commit, files).catch(err => {
        console.error(err);
        process.exit(1);
--- a/build/azure-pipelines/common/releaseBuild.js
+++ b/build/azure-pipelines/common/releaseBuild.js
@@ -39,7 +39,7 @@ async function main() {
    }
    console.log(`Releasing build ${commit}...`);
    const scripts = client.database('builds').container(quality).scripts;
-    await retry_1.retry(() => scripts.storedProcedure('releaseBuild').execute('', [commit]));
+    await (0, retry_1.retry)(() => scripts.storedProcedure('releaseBuild').execute('', [commit]));
 }
 main().then(() => {
    console.log('Build successfully released');
--- a/build/azure-pipelines/common/sync-mooncake.js
+++ b/build/azure-pipelines/common/sync-mooncake.js
@@ -62,7 +62,7 @@ async function sync(commit, quality) {
            await new Promise((c, e) => readStream.pipe(writeStream).on('finish', c).on('error', e));
            log(`  Updating build in DB...`);
            const mooncakeUrl = `${process.env['MOONCAKE_CDN_URL']}${blobPath}`;
-            await retry_1.retry(() => container.scripts.storedProcedure('setAssetMooncakeUrl')
+            await (0, retry_1.retry)(() => container.scripts.storedProcedure('setAssetMooncakeUrl')
                .execute('', [commit, asset.platform, asset.type, mooncakeUrl]));
            log(`  Done ✔️`);
        }
--- a/build/azure-pipelines/docker/Dockerfile
+++ b/build/azure-pipelines/docker/Dockerfile
@@ -1,10 +1,14 @@
-#Download base image ubuntu 18.04
-FROM ubuntu:18.04
+#Download base image ubuntu 21.04
+FROM ubuntu:21.04
+ENV TZ=America/Los_Angeles
+RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone

 # Update Software repository
-RUN apt-get update
+RUN apt-get update && apt-get upgrade -y

-RUN apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus libgtk-3-0
+RUN apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 \
+        libkrb5-dev git apt-transport-https ca-certificates curl gnupg-agent software-properties-common \
+        libnss3 libasound2 make gcc libx11-dev fakeroot rpm libgconf-2-4 libunwind8 g++  python3-dev python3-pip

 ADD ./ /opt/ads-server

--- a/build/azure-pipelines/linux/createDrop.sh
+++ b/build/azure-pipelines/linux/createDrop.sh
@@ -14,22 +14,4 @@ TARBALL_PATH="$REPO/.build/linux/archive/$TARBALL_FILENAME"
 rm -rf $ROOT/code-*.tar.*
 (cd $ROOT && tar -czf $TARBALL_PATH $BUILDNAME)

-# # Publish Remote Extension Host
-# LEGACY_SERVER_BUILD_NAME="azuredatastudio-reh-$PLATFORM_LINUX"
-# SERVER_BUILD_NAME="azuredatastudio-server-$PLATFORM_LINUX"
-# SERVER_TARBALL_FILENAME="azuredatastudio-server-$PLATFORM_LINUX.tar.gz"
-# SERVER_TARBALL_PATH="$REPO/.build/linux/server/$SERVER_TARBALL_FILENAME"
-
-# rm -rf $ROOT/azuredatastudio-server-*.tar.*
-# (cd $ROOT && mv $LEGACY_SERVER_BUILD_NAME $SERVER_BUILD_NAME && tar --owner=0 --group=0 -czf $SERVER_TARBALL_PATH $SERVER_BUILD_NAME)
-
-# Publish Remote Extension Host (Web)
-LEGACY_SERVER_BUILD_NAME_WEB="azuredatastudio-reh-web-$PLATFORM_LINUX"
-SERVER_BUILD_NAME_WEB="azuredatastudio-server-$PLATFORM_LINUX-web"
-SERVER_TARBALL_FILENAME_WEB="azuredatastudio-server-$PLATFORM_LINUX-web.tar.gz"
-SERVER_TARBALL_PATH_WEB="$REPO/.build/linux/server/$SERVER_TARBALL_FILENAME_WEB"
-
-rm -rf $ROOT/azuredatastudio-server-*.tar.*
-(cd $ROOT && mv vscode-reh-web-linux-x64 $SERVER_BUILD_NAME_WEB && tar --owner=0 --group=0 -czf $SERVER_TARBALL_PATH_WEB $SERVER_BUILD_NAME_WEB)
-
 node build/azure-pipelines/common/copyArtifacts.js
--- a/build/azure-pipelines/linux/sql-product-build-linux.yml
+++ b/build/azure-pipelines/linux/sql-product-build-linux.yml
@@ -94,8 +94,6 @@ steps:
  - script: |
      set -e
      yarn gulp vscode-linux-x64-min-ci
-      yarn gulp vscode-web-min-ci
-      yarn gulp vscode-reh-web-linux-x64-min
    displayName: Build
    env:
      VSCODE_MIXIN_PASSWORD: $(github-distro-mixin-password)
@@ -224,19 +222,6 @@ steps:
    displayName: 'Signing Extensions and Langpacks'
    condition: and(succeeded(), eq(variables['signed'], true))

-  # - script: |
-  #     set -e
-  #     cd ./extensions/mssql/node_modules/@microsoft/ads-kerberos
-  #     # npx node-gyp rebuild
-  #     yarn install
-  #   displayName: Recompile native node modules
-
-  # - script: |
-  #     set -e
-  #     VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
-  #         yarn gulp vscode-reh-web-linux-x64-min
-  #   displayName: Build web server
-
  - script: |
      set -e
      ./build/azure-pipelines/linux/createDrop.sh
--- a/build/azure-pipelines/publish-types/update-types.js
+++ b/build/azure-pipelines/publish-types/update-types.js
@@ -60,7 +60,7 @@ function getNewFileHeader(tag) {
        `/*---------------------------------------------------------------------------------------------`,
        ` *  Copyright (c) Microsoft Corporation. All rights reserved.`,
        ` *  Licensed under the Source EULA.`,
-        ` *  See https://github.com/Microsoft/vscode/blob/master/LICENSE.txt for license information.`,
+        ` *  See https://github.com/Microsoft/vscode/blob/main/LICENSE.txt for license information.`,
        ` *--------------------------------------------------------------------------------------------*/`,
        ``,
        `/**`,
--- a/build/azure-pipelines/sql-product-build.yml
+++ b/build/azure-pipelines/sql-product-build.yml
@@ -50,30 +50,6 @@ jobs:
      extensionsToUnitTest: ["admin-tool-ext-win", "agent", "azdata", "azurecore", "cms", "dacpac", "import", "schema-compare", "notebook", "resource-deployment", "machine-learning", "sql-database-projects", "data-workspace"]
  timeoutInMinutes: 90

- job: LinuxWeb
-  condition: and(succeeded(), eq(variables['VSCODE_BUILD_WEB'], 'true'), ne(variables['VSCODE_QUALITY'], 'saw'))
-  pool:
-    vmImage: 'Ubuntu-18.04'
-  container: linux-x64
-  variables:
-    VSCODE_ARCH: x64
-  dependsOn:
-  - Compile
-  steps:
-  - template: web/sql-product-build-web.yml
-  timeoutInMinutes: 90
-
- job: Docker
-  condition: and(succeeded(), eq(variables['VSCODE_BUILD_DOCKER'], 'true'))
-  pool:
-    vmImage: 'Ubuntu-18.04'
-  container: linux-x64
-  dependsOn:
-  - Linux
-  steps:
-  - template: docker/sql-product-build-docker.yml
-  timeoutInMinutes: 90
-
 - job: Windows
  condition: and(succeeded(), eq(variables['VSCODE_BUILD_WIN32'], 'true'))
  pool:
@@ -102,10 +78,8 @@ jobs:
  dependsOn:
  - macOS
  - Linux
-  # - Docker
  - Windows
  - Windows_Test
-  - LinuxWeb
  - macOS_Signing
  steps:
  - template: sql-release.yml
--- a/build/azure-pipelines/sql-product-compile.yml
+++ b/build/azure-pipelines/sql-product-compile.yml
@@ -91,8 +91,6 @@ steps:
    yarn gulp compile-build
    yarn gulp compile-extensions-build
    yarn gulp minify-vscode
-    yarn gulp vscode-reh-linux-x64-min
-    yarn gulp vscode-reh-web-linux-x64-min
  displayName: Compile

 - script: |
--- a/build/azure-pipelines/sql-web-build.yml
+++ b/build/azure-pipelines/sql-web-build.yml
@@ -0,0 +1,29 @@
+resources:
+  containers:
+  - container: linux-x64
+    image: sqltoolscontainers.azurecr.io/web-build-image:1
+    endpoint: ContainerRegistry
+
+jobs:
+- job: LinuxWeb
+  pool:
+    vmImage: 'Ubuntu-18.04'
+  container: linux-x64
+  variables:
+    VSCODE_ARCH: x64
+  steps:
+  - template: web/sql-product-build-web.yml
+  timeoutInMinutes: 90
+
+- job: Docker
+  pool:
+    vmImage: 'Ubuntu-18.04'
+  container: linux-x64
+  dependsOn:
+  - LinuxWeb
+  steps:
+  - template: docker/sql-product-build-docker.yml
+  timeoutInMinutes: 90
+
+trigger: none
+pr: none
--- a/build/azure-pipelines/web/build/Dockerfile
+++ b/build/azure-pipelines/web/build/Dockerfile
@@ -0,0 +1,24 @@
+#Download base image ubuntu 21.04
+FROM ubuntu:21.04
+ENV TZ=America/Los_Angeles
+RUN ln -snf /usr/share/zoneinfo/$TZ /etc/localtime && echo $TZ > /etc/timezone
+
+# Update Software repository
+RUN apt-get update && apt-get upgrade -y
+
+RUN apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 dbus xvfb libgtk-3-0 \
+	libkrb5-dev git apt-transport-https ca-certificates curl gnupg-agent software-properties-common \
+	libnss3 libasound2 make gcc libx11-dev fakeroot rpm libgconf-2-4 libunwind8 g++ python
+
+#docker
+RUN curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add -
+RUN apt-key fingerprint 0EBFCD88
+RUN add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/ubuntu $(lsb_release -cs) stable"
+RUN apt-get update
+RUN apt-get -y install docker-ce docker-ce-cli containerd.io
+
+# This image needs to be built on a linux host; some weird stuff happens and the xvfb service won't start
+# if built on a windows host.
+ADD ./xvfb.init /etc/init.d/xvfb
+RUN chmod +x /etc/init.d/xvfb
+RUN update-rc.d xvfb defaults
--- a/build/azure-pipelines/web/build/xvfb.init
+++ b/build/azure-pipelines/web/build/xvfb.init
@@ -0,0 +1,53 @@
+#!/bin/bash
+#
+# /etc/rc.d/init.d/xvfbd
+#
+# chkconfig: 345 95 28
+# description: Starts/Stops X Virtual Framebuffer server
+# processname: Xvfb
+#
+### BEGIN INIT INFO
+# Provides:          xvfb
+# Required-Start:    $remote_fs $syslog
+# Required-Stop:     $remote_fs $syslog
+# Default-Start:     2 3 4 5
+# Default-Stop:      0 1 6
+# Short-Description: Start xvfb at boot time
+# Description:       Enable xvfb provided by daemon.
+### END INIT INFO
+
+[ "${NETWORKING}" = "no" ] && exit 0
+
+PROG="/usr/bin/Xvfb"
+PROG_OPTIONS=":10 -ac -screen 0 1024x768x24"
+PROG_OUTPUT="/tmp/Xvfb.out"
+
+case "$1" in
+	start)
+		echo "Starting : X Virtual Frame Buffer "
+		$PROG $PROG_OPTIONS>>$PROG_OUTPUT 2>&1 &
+		disown -ar
+	;;
+	stop)
+		echo "Shutting down : X Virtual Frame Buffer"
+		killproc $PROG
+		RETVAL=$?
+		[ $RETVAL -eq 0 ] && /bin/rm -f /var/lock/subsys/Xvfb
+		/var/run/Xvfb.pid
+		echo
+	;;
+	restart|reload)
+		$0 stop
+		$0 start
+		RETVAL=$?
+	;;
+	status)
+		status Xvfb
+		RETVAL=$?
+	;;
+	*)
+		echo $"Usage: $0 (start|stop|restart|reload|status)"
+		exit 1
+esac
+
+exit $RETVAL
--- a/build/azure-pipelines/web/createDrop.sh
+++ b/build/azure-pipelines/web/createDrop.sh
@@ -0,0 +1,35 @@
+#!/usr/bin/env bash
+set -e
+REPO="$(pwd)"
+ROOT="$REPO/.."
+
+# Publish tarball
+mkdir -p $REPO/.build/linux/{archive,server}
+PLATFORM_LINUX="linux-x64"
+BUILDNAME="azuredatastudio-$PLATFORM_LINUX"
+BUILD="$ROOT/$BUILDNAME"
+TARBALL_FILENAME="azuredatastudio-$PLATFORM_LINUX.tar.gz"
+TARBALL_PATH="$REPO/.build/linux/archive/$TARBALL_FILENAME"
+
+rm -rf $ROOT/code-*.tar.*
+(cd $ROOT && tar -czf $TARBALL_PATH $BUILDNAME)
+
+# # Publish Remote Extension Host
+# LEGACY_SERVER_BUILD_NAME="azuredatastudio-reh-$PLATFORM_LINUX"
+# SERVER_BUILD_NAME="azuredatastudio-server-$PLATFORM_LINUX"
+# SERVER_TARBALL_FILENAME="azuredatastudio-server-$PLATFORM_LINUX.tar.gz"
+# SERVER_TARBALL_PATH="$REPO/.build/linux/server/$SERVER_TARBALL_FILENAME"
+
+# rm -rf $ROOT/azuredatastudio-server-*.tar.*
+# (cd $ROOT && mv $LEGACY_SERVER_BUILD_NAME $SERVER_BUILD_NAME && tar --owner=0 --group=0 -czf $SERVER_TARBALL_PATH $SERVER_BUILD_NAME)
+
+# Publish Remote Extension Host (Web)
+LEGACY_SERVER_BUILD_NAME_WEB="azuredatastudio-reh-web-$PLATFORM_LINUX"
+SERVER_BUILD_NAME_WEB="azuredatastudio-server-$PLATFORM_LINUX-web"
+SERVER_TARBALL_FILENAME_WEB="azuredatastudio-server-$PLATFORM_LINUX-web.tar.gz"
+SERVER_TARBALL_PATH_WEB="$REPO/.build/linux/server/$SERVER_TARBALL_FILENAME_WEB"
+
+rm -rf $ROOT/azuredatastudio-server-*.tar.*
+(cd $ROOT && mv vscode-reh-web-linux-x64 $SERVER_BUILD_NAME_WEB && tar --owner=0 --group=0 -czf $SERVER_TARBALL_PATH_WEB $SERVER_BUILD_NAME_WEB)
+
+node build/azure-pipelines/common/copyArtifacts.js
--- a/build/azure-pipelines/web/sql-product-build-web.yml
+++ b/build/azure-pipelines/web/sql-product-build-web.yml
@@ -1,4 +1,3 @@
-
 steps:
 - task: NodeTool@0
  inputs:
@@ -13,17 +12,6 @@ steps:
  inputs:
    azureSubscription: 'ClientToolsInfra_670062 (88d5392f-a34f-4769-b405-f597fc533613)'
    KeyVaultName: ado-secrets
-    SecretsFilter: 'github-distro-mixin-password'
-
- task: DownloadPipelineArtifact@2
-  inputs:
-    artifact: Compilation
-  displayName: Download compilation output
-
- script: |
-    set -e
-    tar -xzf $(Pipeline.Workspace)/compilation.tar.gz
-  displayName: Extract compilation output

 - script: |
    set -e
@@ -44,33 +32,46 @@ steps:
    git merge $(node -p "require('./package.json').distro")
  displayName: Merge distro

-# - task: 1ESLighthouseEng.PipelineArtifactCaching.RestoreCacheV1.RestoreCache@1
-#   displayName: Restore Cache - Node Modules
-#   inputs:
-#     keyfile: 'build/.cachesalt, .yarnrc, remote/.yarnrc, **/yarn.lock, !**/node_modules/**/yarn.lock, !**/.*/**/yarn.lock'
-#     targetfolder: '**/node_modules, !**/node_modules/**/node_modules'
-#     vstsFeed: 'npm-vscode'
+- script: |
+    mkdir -p .build
+    node build/azure-pipelines/common/sql-computeNodeModulesCacheKey.js > .build/yarnlockhash
+  displayName: Prepare yarn cache key
+
+- task: Cache@2
+  inputs:
+    key: 'nodeModules | $(Agent.OS) | .build/yarnlockhash'
+    path: .build/node_modules_cache
+    cacheHitVar: NODE_MODULES_RESTORED
+  displayName: Restore Cache - Node Modules
+
+- script: |
+    set -e
+    tar -xzf .build/node_modules_cache/cache.tgz
+  condition: and(succeeded(), eq(variables.NODE_MODULES_RESTORED, 'true'))
+  displayName: Extract node_modules archive

 - script: |
    set -e
    CHILD_CONCURRENCY=1 yarn --frozen-lockfile
  displayName: Install dependencies
-  # condition: and(succeeded(), ne(variables['CacheRestored'], 'true'))
+  condition: and(succeeded(), ne(variables['NODE_MODULES_RESTORED'], 'true'))

-# - task: 1ESLighthouseEng.PipelineArtifactCaching.SaveCacheV1.SaveCache@1
-#   displayName: Save Cache - Node Modules
-#   inputs:
-#     keyfile: 'build/.cachesalt, .yarnrc, remote/.yarnrc, **/yarn.lock, !**/node_modules/**/yarn.lock, !**/.*/**/yarn.lock'
-#     targetfolder: '**/node_modules, !**/node_modules/**/node_modules'
-#     vstsFeed: 'npm-vscode'
-#   condition: and(succeeded(), ne(variables['CacheRestored'], 'true'))
+- script: |
+    set -e
+    node build/azure-pipelines/common/listNodeModules.js .build/node_modules_list.txt
+    mkdir -p .build/node_modules_cache
+    tar -czf .build/node_modules_cache/cache.tgz --files-from .build/node_modules_list.txt
+  condition: and(succeeded(), ne(variables.NODE_MODULES_RESTORED, 'true'))
+  displayName: Create node_modules archive

-# - script: |
-#     set -e
-#     yarn postinstall
-#   displayName: Run postinstall scripts
-#   condition: and(succeeded(), eq(variables['CacheRestored'], 'true'))
+- script: |
+    set -e
+    yarn postinstall
+  displayName: Run postinstall scripts
+  condition: and(succeeded(), eq(variables['NODE_MODULES_RESTORED'], 'true'))

+# Mixin must run before optimize, because the CSS loader will
+# inline small SVGs
 - script: |
    set -e
    node build/azure-pipelines/mixin
@@ -78,25 +79,128 @@ steps:

 - script: |
    set -e
-    VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
-      yarn gulp vscode-web-min-ci
-  displayName: Build
+    yarn sqllint
+    yarn gulp hygiene
+    yarn strict-vscode
+    yarn valid-layers-check
+  displayName: Run hygiene, eslint
+  condition: and(succeeded(), eq(variables['VSCODE_STEP_ON_IT'], 'false'))

-  # upload only the workbench.web.api.js source maps because
-  # we just compiled these bits in the previous step and the
-  # general task to upload source maps has already been run
 - script: |
    set -e
-    AZURE_STORAGE_ACCOUNT="$(sourcemap-storage-account)" \
-    AZURE_STORAGE_ACCESS_KEY="$(sourcemap-storage-key)" \
-      node build/azure-pipelines/upload-sourcemaps out-vscode-web-min out-vscode-web-min/vs/workbench/workbench.web.api.js.map
-  displayName: Upload sourcemaps (Web)
+    yarn gulp compile-build
+    yarn gulp compile-extensions-build
+    yarn gulp minify-vscode
+    yarn gulp vscode-linux-x64-min-ci
+    yarn gulp vscode-web-min-ci
+    yarn gulp vscode-reh-linux-x64-min
+    yarn gulp vscode-reh-web-linux-x64-yarnrc-extensions
+    yarn gulp vscode-reh-web-linux-x64-min
+  displayName: Compile

 # - script: |
 #     set -e
-#     AZURE_DOCUMENTDB_MASTERKEY="$(builds-docdb-key-readwrite)" \
-#     AZURE_STORAGE_ACCESS_KEY_2="$(vscode-storage-key)" \
-#     VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
-#     ./build/azure-pipelines/web/publish.sh
-#   displayName: Publish
+#     AZURE_STORAGE_ACCOUNT="$(sourcemap-storage-account)" \
+#     AZURE_STORAGE_ACCESS_KEY="$(sourcemap-storage-key)" \
+#       node build/azure-pipelines/upload-sourcemaps
+#   displayName: Upload sourcemaps

+- script: |
+    set -e
+
+    VERSION=$(node -p "require(\"./package.json\").version")
+
+    echo -e "{  \"version\": \"$VERSION\", \"quality\": \"$VSCODE_QUALITY\", \"commit\": \"$BUILD_SOURCEVERSION\" }" > ".build/version.json"
+
+    node build/azure-pipelines/common/copyArtifacts.js
+  displayName: Write Version Information
+
+- task: PublishBuildArtifacts@1
+  displayName: 'Publish Artifact: drop'
+
+- script: |
+    set -e
+    tar -czf $(Build.ArtifactStagingDirectory)/compilation.tar.gz .build out-*
+  displayName: Compress compilation artifact
+
+- task: PublishPipelineArtifact@1
+  inputs:
+    targetPath: $(Build.ArtifactStagingDirectory)/compilation.tar.gz
+    artifactName: Compilation
+  displayName: Publish compilation artifact
+
+- script: |
+    set -e
+    yarn gulp package-rebuild-extensions
+    yarn gulp compile-extensions
+    yarn gulp package-external-extensions
+  displayName: Package External extensions
+
+- script: |
+    set -e
+    yarn gulp package-langpacks
+  displayName: Package Langpacks
+
+- script: |
+    set -e
+    yarn gulp vscode-linux-x64-build-deb
+  displayName: Build Deb
+
+- script: |
+    set -e
+    yarn gulp vscode-linux-x64-build-rpm
+  displayName: Build Rpm
+
+- task: UseDotNet@2
+  displayName: 'Install .NET Core sdk for signing'
+  inputs:
+    packageType: sdk
+    version: 2.1.x
+    installationPath: $(Agent.ToolsDirectory)/dotnet
+
+- task: SFP.build-tasks.custom-build-task-1.EsrpCodeSigning@1
+  inputs:
+    ConnectedServiceName: 'Code Signing'
+    FolderPath: '$(Build.SourcesDirectory)/.build'
+    Pattern: 'extensions/*.vsix,langpacks/*.vsix'
+    signConfigType: inlineSignParams
+    inlineOperation: |
+      [
+        {
+          "keyCode": "CP-233016",
+          "operationSetCode": "OpcSign",
+          "parameters": [
+            {
+              "parameterName": "FileDigest",
+              "parameterValue": "/fd \"SHA256\""
+            }
+          ],
+          "toolName": "sign",
+          "toolVersion": "1.0"
+        },
+        {
+          "keyCode": "CP-233016",
+          "operationSetCode": "OpcVerify",
+          "parameters": [],
+          "toolName": "sign",
+          "toolVersion": "1.0"
+        }
+      ]
+    SessionTimeout: 120
+  displayName: 'Signing Extensions and Langpacks'
+  condition: and(succeeded(), eq(variables['signed'], true))
+
+- script: |
+    set -e
+    ./build/azure-pipelines/web/createDrop.sh
+  displayName: Create Drop
+
+- task: PublishBuildArtifacts@1
+  displayName: 'Publish Artifact: drop'
+  continueOnError: true
+  condition: succeededOrFailed()
+
+- task: ms.vss-governance-buildtask.governance-build-task-component-detection.ComponentGovernanceComponentDetection@0
+  displayName: 'Component Detection'
+  inputs:
+    failOnAlert: true