From 31f7364f0840890427bd65b9b999f1a2a68e46d2 Mon Sep 17 00:00:00 2001 From: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Date: Thu, 18 Apr 2019 14:57:11 -0700 Subject: [PATCH] Only show nb loading spinner when no cells shown (#5095) --- src/sql/workbench/parts/notebook/notebook.component.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sql/workbench/parts/notebook/notebook.component.ts b/src/sql/workbench/parts/notebook/notebook.component.ts index 6ea2dad117..586e069543 100644 --- a/src/sql/workbench/parts/notebook/notebook.component.ts +++ b/src/sql/workbench/parts/notebook/notebook.component.ts @@ -224,7 +224,6 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe try { await this.setNotebookManager(); await this.loadModel(); - this.setLoading(false); this._modelReadyDeferred.resolve(this._model); } catch (error) { this.setViewInErrorState(localize('displayFailed', 'Could not display contents: {0}', notebookUtils.getErrorMessage(error))); @@ -262,6 +261,7 @@ export class NotebookComponent extends AngularDisposable implements OnInit, OnDe model.contentChanged((change) => this.handleContentChanged(change)); model.onProviderIdChange((provider) => this.handleProviderIdChanged(provider)); this._model = this._register(model); + this.setLoading(false); this.updateToolbarComponents(this._model.trustedMode); this._modelRegisteredDeferred.resolve(this._model); await model.startSession(this.model.notebookManager, undefined, true);