ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-20 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

change userName to match what the azure account display name is (#11484)

Browse Source 
* change userName to match what the azure account display name is

* Handle undefined value
This commit is contained in:
Amir Omidi
2020-07-22 19:31:52 -07:00
committed by GitHub
parent 196b3752a9
commit 32047d5557
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sql/base/browser/ui/selectBox/selectBox.ts
View File

@@ -197,6 +197,10 @@ export class SelectBox extends vsSelectBox {
return this._selectedOption;
}
public get label(): string | undefined {
return this._dialogOptions.find(s => s.value === this._selectedOption).text;
}
public get values(): string[] {
return this._dialogOptions.map(s => s.value);
}

16
src/sql/base/test/browser/ui/selectBox/selectBox.test.ts
View File

@@ -6,6 +6,7 @@
import * as assert from 'assert';
import { SelectBox, SelectOptionItemSQL } from 'sql/base/browser/ui/selectBox/selectBox';
import { deepClone, equals } from 'vs/base/common/objects';
import { isUndefined } from 'vs/base/common/types';
const options: SelectOptionItemSQL[] = [
{ text: 't1', value: 'v1' },
@@ -45,6 +46,7 @@ suite('Select Box tests', () => {
});
assert(sb.value === options[0].value);
assert(sb.label === options[0].text);
});
test('values get auto populated', () => {
@@ -53,4 +55,18 @@ suite('Select Box tests', () => {
assert(equals(sb.values, newOptions.map(s => s.text)));
});
test('value did not contain label', () => {
const newOptions = deepClone(options).map(s => { return { text: s.text, value: undefined }; });
delete newOptions[0].text;
const sb = new SelectBox(newOptions, undefined, undefined, undefined, undefined);
sb.onSelect({
index: 0,
selected: options[0].value
});
assert(isUndefined(sb.label));
});
});