From 3220f8a0b423b36faa7a6c484270a7ad87a1db4a Mon Sep 17 00:00:00 2001 From: Alan Ren Date: Fri, 25 Sep 2020 10:54:47 -0700 Subject: [PATCH] update new button role on welcome page (#12630) --- src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts index c7927e7844..0b2b7ea510 100644 --- a/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts +++ b/src/sql/workbench/contrib/welcome/page/browser/welcomePage.ts @@ -361,13 +361,13 @@ class WelcomePage extends Disposable { const getDropdownBtn = container.querySelector('#dropdown-btn-container .monaco-button') as HTMLElement; getDropdownBtn.id = 'dropdown-btn'; - getDropdownBtn.setAttribute('role', 'navigation'); + getDropdownBtn.setAttribute('role', 'button'); getDropdownBtn.setAttribute('aria-haspopup', 'true'); getDropdownBtn.setAttribute('aria-controls', 'dropdown'); nav.setAttribute('role', 'navigation'); nav.classList.add('dropdown-nav'); dropdownUl.classList.add('dropdown'); - getDropdownBtn.id = 'dropdown-btn'; + getDropdownBtn.setAttribute('aria-expanded', 'false'); getDropdownBtn.appendChild(i); nav.appendChild(dropdownUl); dropdownButtonContainer.appendChild(nav);