diff --git a/src/sql/parts/modelComponents/componentBase.ts b/src/sql/parts/modelComponents/componentBase.ts index c60fbbc32c..c51ebc5254 100644 --- a/src/sql/parts/modelComponents/componentBase.ts +++ b/src/sql/parts/modelComponents/componentBase.ts @@ -98,10 +98,6 @@ export abstract class ComponentBase extends Disposable implements IComponent, On if (enabled === undefined) { enabled = true; properties['enabled'] = enabled; - this.fireEvent({ - eventType: ComponentEventType.PropertiesChanged, - args: this.getProperties() - }); } return enabled; } diff --git a/src/sql/parts/modelComponents/dropdown.component.ts b/src/sql/parts/modelComponents/dropdown.component.ts index 51cf205d0e..ead4629c33 100644 --- a/src/sql/parts/modelComponents/dropdown.component.ts +++ b/src/sql/parts/modelComponents/dropdown.component.ts @@ -145,15 +145,11 @@ export default class DropDownComponent extends ComponentBase implements ICompone private getSelectedValue(): string { if (this.values && this.values.length > 0 && this.valuesHaveDisplayName()) { let selectedValue = this.value || this.values[0]; - if (!this.value) { - this.value = selectedValue; - } let valueCategory = (this.values).find(v => v.name === selectedValue.name); - return valueCategory && valueCategory.displayName; } else { if (!this.value && this.values && this.values.length > 0) { - this.value = this.values[0]; + return this.values[0]; } return this.value; } @@ -198,11 +194,11 @@ export default class DropDownComponent extends ComponentBase implements ICompone this.setPropertyFromUI(this.setValuesProperties, newValue); } - private setValueProperties(properties: sqlops.DropDownProperties, value: string): void { + private setValueProperties(properties: sqlops.DropDownProperties, value: string | sqlops.CategoryValue): void { properties.value = value; } - private setValuesProperties(properties: sqlops.DropDownProperties, values: string[]): void { + private setValuesProperties(properties: sqlops.DropDownProperties, values: string[] | sqlops.CategoryValue[]): void { properties.values = values; } } diff --git a/src/sql/workbench/api/node/extHostModelView.ts b/src/sql/workbench/api/node/extHostModelView.ts index 7c2e3b93a1..80f9aad992 100644 --- a/src/sql/workbench/api/node/extHostModelView.ts +++ b/src/sql/workbench/api/node/extHostModelView.ts @@ -380,7 +380,8 @@ class ComponentWrapper implements sqlops.Component { } public get enabled(): boolean { - return this.properties['enabled']; + let isEnabled = this.properties['enabled']; + return (isEnabled === undefined) ? true : isEnabled; } public set enabled(value: boolean) { @@ -782,7 +783,11 @@ class DropDownWrapper extends ComponentWrapper implements sqlops.DropDownCompone } public get value(): string | sqlops.CategoryValue { - return this.properties['value']; + let val = this.properties['value']; + if (!val && this.values && this.values.length > 0) { + val = this.values[0]; + } + return val; } public set value(v: string | sqlops.CategoryValue) { this.setProperty('value', v);