Alanren/modal message high contrast fix (#3018)

* make modal dialog message section HC aware

* handle warning icon
This commit is contained in:
Alan Ren
2018-10-26 15:38:51 -07:00
committed by GitHub
parent ff5a248240
commit 3237507bb2
18 changed files with 67 additions and 39 deletions

View File

@@ -67,7 +67,7 @@ export class AccountDialog extends Modal {
constructor(
@IPartService partService: IPartService,
@IThemeService private _themeService: IThemeService,
@IThemeService themeService: IThemeService,
@IListService private _listService: IListService,
@IInstantiationService private _instantiationService: IInstantiationService,
@IContextMenuService private _contextMenuService: IContextMenuService,
@@ -82,6 +82,7 @@ export class AccountDialog extends Modal {
partService,
telemetryService,
clipboardService,
themeService,
contextKeyService,
{ hasSpinner: true }
);

View File

@@ -43,7 +43,7 @@ export class AutoOAuthDialog extends Modal {
constructor(
@IPartService partService: IPartService,
@IThemeService private _themeService: IThemeService,
@IThemeService themeService: IThemeService,
@IContextViewService private _contextViewService: IContextViewService,
@ITelemetryService telemetryService: ITelemetryService,
@IContextKeyService contextKeyService: IContextKeyService,
@@ -55,6 +55,7 @@ export class AutoOAuthDialog extends Modal {
partService,
telemetryService,
clipboardService,
themeService,
contextKeyService,
{
isFlyout: true,

View File

@@ -65,7 +65,7 @@ export class FirewallRuleDialog extends Modal {
constructor(
@IAccountPickerService private _accountPickerService: IAccountPickerService,
@IPartService partService: IPartService,
@IWorkbenchThemeService private _themeService: IWorkbenchThemeService,
@IWorkbenchThemeService private _workbenchThemeService: IWorkbenchThemeService,
@IInstantiationService private _instantiationService: IInstantiationService,
@IContextViewService private _contextViewService: IContextViewService,
@ITelemetryService telemetryService: ITelemetryService,
@@ -79,6 +79,7 @@ export class FirewallRuleDialog extends Modal {
partService,
telemetryService,
clipboardService,
_workbenchThemeService,
contextKeyService,
{
isFlyout: true,
@@ -205,8 +206,8 @@ export class FirewallRuleDialog extends Modal {
builder.append(firewallRuleSection);
});
this._register(this._themeService.onDidColorThemeChange(e => this.updateTheme(e)));
this.updateTheme(this._themeService.getColorTheme());
this._register(this._workbenchThemeService.onDidColorThemeChange(e => this.updateTheme(e)));
this.updateTheme(this._workbenchThemeService.getColorTheme());
$(this._IPAddressInput).on(DOM.EventType.CLICK, () => {
this.onFirewallRuleOptionSelected(true);