From 32b912c37e91eebb8eccded2fef61362ca9d2ce3 Mon Sep 17 00:00:00 2001
From: Charles Gagnon <chgagnon@microsoft.com>
Date: Mon, 4 Oct 2021 13:35:24 -0700
Subject: [PATCH] Clean up tsconfig.base.json (#17220)

* Clean up tsconfig.base.json

* revert param name

* Try removing comments

* use newer option again

* revert option again

* more
---
 extensions/sql-database-projects/package.json |  1 -
 src/tsconfig.base.json                        | 10 ++++------
 2 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/extensions/sql-database-projects/package.json b/extensions/sql-database-projects/package.json
index 5d5d21ff28..eb1f68e882 100644
--- a/extensions/sql-database-projects/package.json
+++ b/extensions/sql-database-projects/package.json
@@ -427,7 +427,6 @@
     "sinon": "^9.0.2",
     "tslint": "^5.8.0",
     "typemoq": "^2.1.0",
-    "typescript": "^2.6.1",
     "vscodetestcover": "^1.1.0"
   },
   "__metadata": {
diff --git a/src/tsconfig.base.json b/src/tsconfig.base.json
index 173cdaea15..9f77ed869e 100644
--- a/src/tsconfig.base.json
+++ b/src/tsconfig.base.json
@@ -2,18 +2,16 @@
 	"compilerOptions": {
 		"module": "amd",
 		"moduleResolution": "node",
-		"noImplicitAny": false,
 		"experimentalDecorators": true,
 		"noImplicitReturns": true,
 		"noImplicitOverride": true,
 		"noUnusedLocals": true,
-		"noImplicitThis": true,
-		"alwaysStrict": true,
-		"strictBindCallApply": true,
-		"strictNullChecks": false,
-		"strictPropertyInitialization": false,
 		"allowUnreachableCode": false,
 		"strict": true,
+		// Much of our code isn't strict-null compliant so disable these for now
+		"strictNullChecks": false,
+		// Disable since without strictNullChecks this has lots of errors in both vs and our code
+		"noImplicitAny": false,
 		"strictOptionalProperties": false,
 		"useUnknownInCatchVariables": false,
 		"forceConsistentCasingInFileNames": true,