ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-01-26 09:35:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

add tab navigation option for slickgrid (#21947)

Browse Source 
* profiler a11y bug fixes

* add new option

* replace old implementation

* update slickgrid
This commit is contained in:
Alan Ren
2023-02-15 21:37:01 -08:00
committed by GitHub
parent 8690c350d2
commit 32c7a4aeec
10 changed files with 26 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sql/workbench/contrib/profiler/browser/profilerEditor.ts
View File

@@ -408,7 +408,8 @@ export class ProfilerEditor extends EditorPane {
]
}, {
forceFitColumns: true,
dataItemColumnValueExtractor: slickGridDataItemColumnValueExtractor
dataItemColumnValueExtractor: slickGridDataItemColumnValueExtractor,
enableInGridTabNavigation: false
});
this._detailTableData.onRowCountChange(() => {

6
src/sql/workbench/contrib/profiler/browser/profilerTableEditor.ts
View File

@@ -96,7 +96,11 @@ export class ProfilerTableEditor extends EditorPane implements IProfilerControll
}
}
}, {
dataItemColumnValueExtractor: slickGridDataItemColumnValueExtractor
dataItemColumnValueExtractor: slickGridDataItemColumnValueExtractor,
// The details component in profiler UI is refreshed based on the selected row in this table.
// If in grid tab navigation is enabled, keyboard-only users will never be able to reach the details component
// when a particular row is selected.
enableInGridTabNavigation: false
});
this._profilerTable.setSelectionModel(new RowSelectionModel());
const copyKeybind = new CopyKeybind();