From 330fb6dff51bab063156ac0d9e4be6aed741a40b Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Tue, 19 Mar 2019 13:46:36 -0700 Subject: [PATCH] Remove tooltip from editable dropdown (#4542) * Fix our custom dropdown control to update the tooltip text correctly when a new value is selected. Previous behavior was to always keep the initial text ( for example). Now we'll update it as appropriate (and default back to Placeholder text when we're clearing the value) * Spaces -> tabs * Remove extra ; * Remove tooltips from the text box part of the dropdown * Remove tooltips from dropdown arrows * Revert "Remove tooltips from dropdown arrows" This reverts commit 31a0748aaea42d5009eb9752bd075ce49a6716f5. --- src/sql/base/browser/ui/editableDropdown/dropdown.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/sql/base/browser/ui/editableDropdown/dropdown.ts b/src/sql/base/browser/ui/editableDropdown/dropdown.ts index a5c22deea9..03e752b2e2 100644 --- a/src/sql/base/browser/ui/editableDropdown/dropdown.ts +++ b/src/sql/base/browser/ui/editableDropdown/dropdown.ts @@ -129,6 +129,10 @@ export class Dropdown extends Disposable { ariaLabel: this._options.ariaLabel }); + // Clear title from input box element (defaults to placeholder value) since we don't want a tooltip for the selected value + // in the text box - we already have tooltips for each item in the dropdown itself. + this._input.inputElement.title = ''; + this._register(DOM.addDisposableListener(this._input.inputElement, DOM.EventType.CLICK, () => { this._showList(); }));