ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-06 01:25:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix endpoint links to not overflow text (#7312)

Browse Source 
* Fix endpoint links to not overflow

* Add titles to links

* Re-add title to Text and fix errors
This commit is contained in:
Charles Gagnon
2019-09-26 11:47:22 -07:00
committed by GitHub
parent 2d9f6dcd86
commit 33854d42e4
12 changed files with 114 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/resource-deployment/src/ui/deployClusterWizard/pages/serviceSettingsPage.ts
View File

@@ -526,7 +526,7 @@ export class ServiceSettingsPage extends WizardPageBase<DeployClusterWizard> {
this.setEnableHadrCheckboxState(Number.parseInt(selectedValue));
}));
this.wizard.registerDisposable(enableHadrCheckbox.onChanged(() => {
this.updateReadableSecondaryEndpointComponents(enableHadrCheckbox.checked);
this.updateReadableSecondaryEndpointComponents(!!enableHadrCheckbox.checked);
}));
}
@@ -534,7 +534,7 @@ export class ServiceSettingsPage extends WizardPageBase<DeployClusterWizard> {
// 1. it is ok to enable HADR when there is only 1 replica
// 2. if there are multiple replicas, the hadr.enabled switch must be set to true.
const enableHadrCheckbox = getCheckboxComponent(VariableNames.EnableHADR_VariableName, this.inputComponents);
const hadrEnabled = sqlInstances === 1 ? enableHadrCheckbox.checked : true;
const hadrEnabled = sqlInstances === 1 ? !!enableHadrCheckbox.checked : true;
if (sqlInstances === 1) {
enableHadrCheckbox.enabled = true;
} else {

6
extensions/resource-deployment/src/ui/modelViewUtils.ts
View File

@@ -415,15 +415,17 @@ export function setModelValues(inputComponents: InputComponents, model: Model):
Object.keys(inputComponents).forEach(key => {
let value;
const input = inputComponents[key];
if ('checked' in input) {
if ('checked' in input) { // CheckBoxComponent
value = input.checked ? 'true' : 'false';
} else {
} else if ('value' in input) { // InputBoxComponent or DropDownComponent
const inputValue = input.value;
if (typeof inputValue === 'string' || typeof inputValue === 'undefined') {
value = inputValue;
} else {
value = inputValue.name;
}
} else {
throw new Error(`Unknown input type with ID ${input.id}`);
}
model.setPropertyValue(key, value);

2
extensions/resource-deployment/src/ui/resourceTypePickerDialog.ts
View File

@@ -236,7 +236,7 @@ export class ResourceTypePickerDialog extends DialogBase {
const checkbox = this._view.modelBuilder.checkBox().component();
checkbox.checked = false;
this._toDispose.push(checkbox.onChanged(() => {
this._agreementCheckboxChecked = checkbox.checked;
this._agreementCheckboxChecked = !!checkbox.checked;
}));
const text = this._view.modelBuilder.text().withProperties<azdata.TextComponentProperties>({
value: agreementInfo.template,