fix aria label for message items (#23283)

This commit is contained in:
Alan Ren
2023-06-01 10:04:36 -07:00
committed by GitHub
parent 30edf8d57b
commit 34268a1190

View File

@@ -70,6 +70,15 @@ const TemplateIds = {
ERROR: 'error' ERROR: 'error'
}; };
function getTimestampDisplayString(message: IResultMessageIntern): string | undefined {
if (message.time) {
const time = isString(message.time) ? new Date(message.time!) : message.time;
return time.toLocaleTimeString();
} else {
return undefined;
}
}
export class AccessibilityProvider implements IListAccessibilityProvider<IResultMessageIntern> { export class AccessibilityProvider implements IListAccessibilityProvider<IResultMessageIntern> {
getWidgetAriaLabel(): string { getWidgetAriaLabel(): string {
@@ -77,7 +86,11 @@ export class AccessibilityProvider implements IListAccessibilityProvider<IResult
} }
getAriaLabel(element: IResultMessageIntern): string { getAriaLabel(element: IResultMessageIntern): string {
return element.message; if (element.time && element.range) {
return localize('messagePanel.message', "Timestamp: {0}, Message: {1}", getTimestampDisplayString(element), element.message);
} else {
return element.message;
}
} }
} }
@@ -321,10 +334,7 @@ class BatchMessageRenderer implements ITreeRenderer<IResultMessageIntern, void,
} }
renderElement(node: ITreeNode<IResultMessageIntern, void>, index: number, templateData: IBatchTemplate): void { renderElement(node: ITreeNode<IResultMessageIntern, void>, index: number, templateData: IBatchTemplate): void {
if (isString(node.element.time)) { templateData.timeStamp.innerText = getTimestampDisplayString(node.element);
node.element.time = new Date(node.element.time!);
}
templateData.timeStamp.innerText = (node.element.time as Date).toLocaleTimeString();
templateData.message.innerText = node.element.message; templateData.message.innerText = node.element.message;
if (node.element.range) { if (node.element.range) {
templateData.disposable.add(addStandardDisposableGenericMouseDownListener(templateData.message, () => { templateData.disposable.add(addStandardDisposableGenericMouseDownListener(templateData.message, () => {