Adding External Streaming Job I/O validation (#13195)

* Added Tools Service call for ValidateStreamingJob

* Partial addition of ESJ

* adding test mocks

* Validation working

* Modifying command visibility logic to submatch ESJs in addition to files

* Changed string literal to constant, corrected attribute order

* Added tests

* correcting casing that's causing test failures on linux

* Swapping Thenable for Promise

* excluded validate from command palette
This commit is contained in:
Benjin Dubishar
2020-11-02 19:02:20 -08:00
committed by GitHub
parent ba80000e27
commit 342ff47e51
20 changed files with 198 additions and 37 deletions

View File

@@ -95,6 +95,11 @@
"title": "%sqlDatabaseProjects.newView%",
"category": "%sqlDatabaseProjects.displayName%"
},
{
"command": "sqlDatabaseProjects.newExternalStreamingJob",
"title": "%sqlDatabaseProjects.newExternalStreamingJob%",
"category": "%sqlDatabaseProjects.displayName%"
},
{
"command": "sqlDatabaseProjects.newStoredProcedure",
"title": "%sqlDatabaseProjects.newStoredProcedure%",
@@ -151,6 +156,11 @@
"title": "%sqlDatabaseProjects.addDatabaseReference%",
"category": "%sqlDatabaseProjects.displayName%"
},
{
"command": "sqlDatabaseProjects.validateExternalStreamingJob",
"title": "%sqlDatabaseProjects.validateExternalStreamingJob%",
"category": "%sqlDatabaseProjects.displayName%"
},
{
"command": "sqlDatabaseProjects.openContainingFolder",
"title": "%sqlDatabaseProjects.openContainingFolder%",
@@ -199,6 +209,10 @@
"command": "sqlDatabaseProjects.newView",
"when": "false"
},
{
"command": "sqlDatabaseProjects.newExternalStreamingJob",
"when": "false"
},
{
"command": "sqlDatabaseProjects.newStoredProcedure",
"when": "false"
@@ -238,6 +252,10 @@
"command": "sqlDatabaseProjects.addDatabaseReference",
"when": "false"
},
{
"command": "sqlDatabaseProjects.validateExternalStreamingJob",
"when": "false"
},
{
"command": "sqlDatabaseProjects.openContainingFolder",
"when": "false"
@@ -308,6 +326,11 @@
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.project || viewItem == databaseProject.itemType.folder",
"group": "3_dbProjects_newItem@3"
},
{
"command": "sqlDatabaseProjects.newExternalStreamingJob",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.project || viewItem == databaseProject.itemType.folder",
"group": "3_dbProjects_newItem@4"
},
{
"command": "sqlDatabaseProjects.newScript",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.project || viewItem == databaseProject.itemType.folder",
@@ -328,14 +351,19 @@
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.referencesRoot",
"group": "4_dbProjects_addDatabaseReference"
},
{
"command": "sqlDatabaseProjects.validateExternalStreamingJob",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.file.externalStreamingJob",
"group": "5_dbProjects_streamingJob"
},
{
"command": "sqlDatabaseProjects.exclude",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.folder || viewItem == databaseProject.itemType.file",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.folder || viewItem =~ /^databaseProject.itemType.file/",
"group": "9_dbProjectsLast@1"
},
{
"command": "sqlDatabaseProjects.delete",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.folder || viewItem == databaseProject.itemType.file || viewItem == databaseProject.itemType.reference",
"when": "view =~ /^(sqlDatabaseProjectsView|dataworkspace.views.main)$/ && viewItem == databaseProject.itemType.folder || viewItem =~ /^databaseProject.itemType.file/ || viewItem == databaseProject.itemType.reference",
"group": "9_dbProjectsLast@2"
},
{