From 35832e83da0dc4848a08a026d34b8ed9d116481b Mon Sep 17 00:00:00 2001 From: Charles Gagnon Date: Thu, 17 Jun 2021 19:38:38 -0700 Subject: [PATCH] Add required field to kube config picker (#15795) --- extensions/arc/src/test/ui/components/filePicker.test.ts | 2 +- extensions/arc/src/ui/components/filePicker.ts | 4 +++- extensions/arc/src/ui/dialogs/connectControllerDialog.ts | 3 ++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/arc/src/test/ui/components/filePicker.test.ts b/extensions/arc/src/test/ui/components/filePicker.test.ts index 141a64259c..8193eb8195 100644 --- a/extensions/arc/src/test/ui/components/filePicker.test.ts +++ b/extensions/arc/src/test/ui/components/filePicker.test.ts @@ -18,7 +18,7 @@ const newFileUri = vscode.Uri.file(path.join('path', 'to', 'new', '.kube', 'conf describe('filePicker', function (): void { beforeEach(async () => { const { modelBuilderMock } = createModelViewMock(); - filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }, '', ''); + filePicker = new FilePicker(modelBuilderMock.object, initialPath, (_disposable) => { }, '', '', true); }); afterEach(() => { diff --git a/extensions/arc/src/ui/components/filePicker.ts b/extensions/arc/src/ui/components/filePicker.ts index 5a424be40e..a9472d6f49 100644 --- a/extensions/arc/src/ui/components/filePicker.ts +++ b/extensions/arc/src/ui/components/filePicker.ts @@ -21,7 +21,8 @@ export class FilePicker { initialPath: string, onNewDisposableCreated: (disposable: vscode.Disposable) => void, ariaLabel: string, - validationErrorMessage: string + validationErrorMessage: string, + required: boolean ) { const buttonWidth = 80; this.filePathInputBox = modelBuilder.inputBox() @@ -29,6 +30,7 @@ export class FilePicker { value: initialPath, ariaLabel: ariaLabel, validationErrorMessage: validationErrorMessage, + required: required, width: 350 }).withValidation(async () => { try { diff --git a/extensions/arc/src/ui/dialogs/connectControllerDialog.ts b/extensions/arc/src/ui/dialogs/connectControllerDialog.ts index 45b17ec122..fd8f09b8db 100644 --- a/extensions/arc/src/ui/dialogs/connectControllerDialog.ts +++ b/extensions/arc/src/ui/dialogs/connectControllerDialog.ts @@ -98,7 +98,8 @@ abstract class ControllerDialogBase extends InitializingComponent { controllerInfo?.kubeConfigFilePath || getDefaultKubeConfigPath(), (disposable) => this._toDispose.push(disposable), loc.controllerKubeConfig, - loc.invalidConfigPath + loc.invalidConfigPath, + true ); this.modelBuilder.inputBox() .withProps({