From 362af3c15347529196f5da4bfbdfe875dc8fbbc5 Mon Sep 17 00:00:00 2001 From: Alex Ma Date: Fri, 3 Jan 2020 16:09:06 -0800 Subject: [PATCH] Changed class name for manage packages extension (#8789) * Adds rule for .icon extensions * revert * Fixed issue and formatted for consistency * reverted change for regular menuentryaction * changed id back to old name * Removed comment * removed space --- .../platform/actions/browser/menuEntryActionViewItem.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/vs/platform/actions/browser/menuEntryActionViewItem.ts b/src/vs/platform/actions/browser/menuEntryActionViewItem.ts index 210bcdefe6..1ecc884123 100644 --- a/src/vs/platform/actions/browser/menuEntryActionViewItem.ts +++ b/src/vs/platform/actions/browser/menuEntryActionViewItem.ts @@ -333,13 +333,13 @@ export class LabeledMenuItemActionItem extends MenuEntryActionViewItem { iconClass = MenuEntryActionViewItem.ICON_PATH_TO_CSS_RULES.get(iconPathMapKey)!; } else { iconClass = ids.nextId(); - createCSSRule(`.icon.${iconClass}`, `background-image: ${asCSSUrl(item.icon.light || item.icon.dark)}`); - createCSSRule(`.vs-dark .icon.${iconClass}, .hc-black .icon.${iconClass}`, `background-image: ${asCSSUrl(item.icon.dark)}`); + createCSSRule(`.codicon.${iconClass}`, `background-image: ${asCSSUrl(item.icon.light || item.icon.dark)}`); + createCSSRule(`.vs-dark .codicon.${iconClass}, .hc-black .codicon.${iconClass}`, `background-image: ${asCSSUrl(item.icon.dark)}`); MenuEntryActionViewItem.ICON_PATH_TO_CSS_RULES.set(iconPathMapKey, iconClass); } - addClasses(this.label, 'icon', iconClass, this._defaultCSSClassToAdd); - this._labeledItemClassDispose = toDisposable(() => removeClasses(this.label, 'icon', iconClass, this._defaultCSSClassToAdd)); + addClasses(this.label, 'codicon', this._defaultCSSClassToAdd, iconClass); + this._labeledItemClassDispose = toDisposable(() => removeClasses(this.label, 'codicon', this._defaultCSSClassToAdd, iconClass)); } }