ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

add migration state management improvement (#17799)

Browse Source 
* add migration state management improvement

* remove extra lines
This commit is contained in:
brian-harris
2021-12-02 15:40:58 -08:00
committed by GitHub
parent 43d235ea42
commit 36364e10c4
1 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
extensions/sql-migration/src/models/migrationLocalStorage.ts
View File

@@ -20,12 +20,14 @@ export class MigrationLocalStorage {
const result: MigrationContext[] = []; const result: MigrationContext[] = [];
const validMigrations: MigrationContext[] = []; const validMigrations: MigrationContext[] = [];
// fetch saved migrations
const migrationMementos: MigrationContext[] = this.context.globalState.get(this.mementoToken) || []; const migrationMementos: MigrationContext[] = this.context.globalState.get(this.mementoToken) || [];
for (let i = 0; i < migrationMementos.length; i++) { for (let i = 0; i < migrationMementos.length; i++) {
const migration = migrationMementos[i]; const migration = migrationMementos[i];
migration.migrationContext = this.removeMigrationSecrets(migration.migrationContext); migration.migrationContext = this.removeMigrationSecrets(migration.migrationContext);
migration.sessionId = migration.sessionId ?? undefinedSessionId; migration.sessionId = migration.sessionId ?? undefinedSessionId;
if (migration.sourceConnectionProfile.serverName === connectionProfile.serverName) { if (migration.sourceConnectionProfile.serverName === connectionProfile.serverName) {
// refresh migration status
if (refreshStatus) { if (refreshStatus) {
try { try {
await this.refreshMigrationAzureAccount(migration); await this.refreshMigrationAzureAccount(migration);
@@ -59,7 +61,25 @@ export class MigrationLocalStorage {
} }
validMigrations.push(migration); validMigrations.push(migration);
} }
await this.context.globalState.update(this.mementoToken, validMigrations);
// only save updated migration context
if (refreshStatus) {
const migrations: MigrationContext[] = this.context.globalState.get(this.mementoToken) || [];
validMigrations.forEach(migration => {
const idx = migrations.findIndex(m => m.migrationContext.id === migration.migrationContext.id);
if (idx > -1) {
migrations[idx] = migration;
}
});
// check global state for migrations count mismatch, avoid saving
// state if the count has changed when a migration may have been added
const current: MigrationContext[] = this.context.globalState.get(this.mementoToken) || [];
if (current.length === migrations.length) {
await this.context.globalState.update(this.mementoToken, migrations);
}
}
return result; return result;
} }