ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 10:58:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Adding a couple telemetry points for sql bindings quickpick (#16974)

Browse Source 
* adding a couple telemetry points for sql bindings quickpick

* addressing comments
This commit is contained in:
Kim Santiago
2021-09-10 14:08:42 -07:00
committed by GitHub
parent 2d609c9cbc
commit 37e88f9fcd
2 changed files with 14 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
extensions/sql-database-projects/src/common/telemetry.ts
View File

@@ -15,7 +15,8 @@ export const TelemetryReporter = new AdsTelemetryReporter(packageInfo.name, pack
export enum TelemetryViews { export enum TelemetryViews {
ProjectController = 'ProjectController', ProjectController = 'ProjectController',
SqlProjectPublishDialog = 'SqlProjectPublishDialog', SqlProjectPublishDialog = 'SqlProjectPublishDialog',
ProjectTree = 'ProjectTree' ProjectTree = 'ProjectTree',
SqlBindingsQuickPick = 'SqlBindingsQuickPick'
} }
export enum TelemetryActions { export enum TelemetryActions {
@@ -32,5 +33,7 @@ export enum TelemetryActions {
build = 'build', build = 'build',
updateProjectForRoundtrip = 'updateProjectForRoundtrip', updateProjectForRoundtrip = 'updateProjectForRoundtrip',
changePlatformType = 'changePlatformType', changePlatformType = 'changePlatformType',
updateSystemDatabaseReferencesInProjFile = 'updateSystemDatabaseReferencesInProjFile' updateSystemDatabaseReferencesInProjFile = 'updateSystemDatabaseReferencesInProjFile',
startAddSqlBinding = 'startAddSqlBinding',
finishAddSqlBinding = 'finishAddSqlBinding'
} }

9
extensions/sql-database-projects/src/dialogs/addSqlBindingQuickpick.ts
View File

@@ -5,8 +5,11 @@ import * as constants from '../common/constants';
import * as utils from '../common/utils'; import * as utils from '../common/utils';
import * as azureFunctionsUtils from '../common/azureFunctionsUtils'; import * as azureFunctionsUtils from '../common/azureFunctionsUtils';
import { PackageHelper } from '../tools/packageHelper'; import { PackageHelper } from '../tools/packageHelper';
import { TelemetryActions, TelemetryReporter, TelemetryViews } from '../common/telemetry';
export async function launchAddSqlBindingQuickpick(uri: vscode.Uri | undefined, packageHelper: PackageHelper): Promise<void> { export async function launchAddSqlBindingQuickpick(uri: vscode.Uri | undefined, packageHelper: PackageHelper): Promise<void> {
TelemetryReporter.sendActionEvent(TelemetryViews.SqlBindingsQuickPick, TelemetryActions.startAddSqlBinding);
if (!uri) { if (!uri) {
// this command only shows in the command palette when the active editor is a .cs file, so we can safely assume that's the scenario // this command only shows in the command palette when the active editor is a .cs file, so we can safely assume that's the scenario
// when this is called without a uri // when this is called without a uri
@@ -115,10 +118,16 @@ export async function launchAddSqlBindingQuickpick(uri: vscode.Uri | undefined,
if (!result.success) { if (!result.success) {
void vscode.window.showErrorMessage(result.errorMessage); void vscode.window.showErrorMessage(result.errorMessage);
TelemetryReporter.sendErrorEvent(TelemetryViews.SqlBindingsQuickPick, TelemetryActions.finishAddSqlBinding);
return; return;
} }
TelemetryReporter.createActionEvent(TelemetryViews.SqlBindingsQuickPick, TelemetryActions.finishAddSqlBinding)
.withAdditionalProperties({ bindingType: selectedBinding.label })
.send();
} catch (e) { } catch (e) {
void vscode.window.showErrorMessage(e); void vscode.window.showErrorMessage(e);
TelemetryReporter.sendErrorEvent(TelemetryViews.SqlBindingsQuickPick, TelemetryActions.finishAddSqlBinding);
return; return;
} }