From 38312de87b8715ad6dd51835611a089cabbf019f Mon Sep 17 00:00:00 2001 From: Aasim Khan Date: Wed, 19 Jul 2023 15:33:26 -0700 Subject: [PATCH] Fixing issue that caused moving connections from one group to other to throw (#23933) --- .../connection/browser/connectionManagementService.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/sql/workbench/services/connection/browser/connectionManagementService.ts b/src/sql/workbench/services/connection/browser/connectionManagementService.ts index ee6a765877..59dd9e7d26 100644 --- a/src/sql/workbench/services/connection/browser/connectionManagementService.ts +++ b/src/sql/workbench/services/connection/browser/connectionManagementService.ts @@ -1431,13 +1431,11 @@ export class ConnectionManagementService extends Disposable implements IConnecti return; } this._connectionStatusManager.changeConnectionUri(newUri, oldUri); - if (!this._uriToProvider[oldUri]) { - this._logService.error(`No provider found for old URI : '${oldUri}'`); - throw new Error(nls.localize('connectionManagementService.noProviderForUri', 'Could not find provider for uri: {0}', oldUri)); + if (this._uriToProvider[oldUri]) { + // Provider will persist after disconnect, it is okay to overwrite the map if it exists from a previously deleted connection. + this._uriToProvider[newUri] = this._uriToProvider[oldUri]; + delete this._uriToProvider[oldUri]; } - // Provider will persist after disconnect, it is okay to overwrite the map if it exists from a previously deleted connection. - this._uriToProvider[newUri] = this._uriToProvider[oldUri]; - delete this._uriToProvider[oldUri]; } /**