ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

Dashboard Minor code cleanup (#894)

Browse Source 
* minor code clean up for dashboard

* formatting
This commit is contained in:
Anthony Dresser
2018-03-13 13:21:21 -07:00
committed by GitHub
parent 64f61b2954
commit 383d74ceb4
8 changed files with 56 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/sql/parts/dashboard/common/dashboardPage.component.ts
View File

@@ -23,6 +23,7 @@ import { DashboardTab } from 'sql/parts/dashboard/common/interfaces';
import * as dashboardHelper from 'sql/parts/dashboard/common/dashboardHelper';
import { WIDGETS_CONTAINER } from 'sql/parts/dashboard/containers/dashboardWidgetContainer.contribution';
import { GRID_CONTAINER } from 'sql/parts/dashboard/containers/dashboardGridContainer.contribution';
import { AngularDisposable } from 'sql/base/common/lifecycle';
import { Registry } from 'vs/platform/registry/common/platform';
import * as types from 'vs/base/common/types';
@@ -46,7 +47,7 @@ const dashboardRegistry = Registry.as<IDashboardRegistry>(DashboardExtensions.Da
selector: 'dashboard-page',
templateUrl: decodeURI(require.toUrl('sql/parts/dashboard/common/dashboardPage.component.html'))
})
export abstract class DashboardPage extends Disposable implements OnDestroy {
export abstract class DashboardPage extends AngularDisposable {
protected tabs: Array<TabConfig> = [];
@@ -259,10 +260,6 @@ export abstract class DashboardPage extends Disposable implements OnDestroy {
}
}
ngOnDestroy() {
this.dispose();
}
private getProperties(): Array<WidgetConfig> {
let properties = this.dashboardService.getSettings<IPropertiesConfig[] | string | boolean>([this.context, 'properties'].join('.'));
this._propertiesConfigLocation = 'default';