CMS Extension - 2 (#4908)

* first set of changes to experiment the registration of cms related apis

* Adding cms service entry to workbench

* Adding basic functionality for add remove reg servers and group

* Returning relative path as part of RegServerResult as string

* initial extension

* cleaned building with connecting to server

* get list of registered servers

* progress with registered servers tree

* cms base node with server selection

* removed unused services

* replaced azure stuff with cms

* removed cmsResourceService

* list servers progress

* Removing the cms apis from core. Having mssql extension expose them for cms extension

* create server working fine

* initial expansion and nodes

* Propogating the backend name changes to apis

* initial cms extension working

* cached connection needs change in api

* connect without dashboard in proposed

* Fixing some missing sqlops references

* add registered server bug found

* added refresh context menu option

* added payload

* server description not disabled after reject connection

* added more context actions and action icons

* added empty resource and error when same name server is added

* fixed connection issues with cms and normal connections

* added initial tests

* added cms icons

* removed azure readme

* test script revert

* fix build tests

* added more cms tests

* fixed test script

* fixed silent error when expanding servers

* added more cms tests

* removed cmsdialog from api

* cms dialog without object

* fixed theming issues

* initial connection dialog done

* can make connections

* PM asks for strings and icons

* removed search

* removed unused code and fixed 1 test

* fix connection management tests

* changed icons

* format file

* fixed hygiene

* initial cr comments

* refactored cms connection dialog

* fixed bug when switching dialogs

* localized connection provider options

* fixed cms provider name

* code review comments

* localized options in cms and mssql

* localized more options

src/sql/platform/connection/common/connectionProfile.ts

@@ -93,6 +93,14 @@ export class ConnectionProfile extends ProviderConnectionInfo implements interfa
 		this.options['azureTenantId'] = value;
 	}
 
+	public get registeredCmsServerDescription(): string {
+		return this.options['registeredCmsServerDescription'];
+	}
+
+	public set registeredCmsServerDescription(value: string) {
+		this.options['registeredCmsServerDescription'] = value;
+	}
+
 	public get groupFullName(): string {
 		return this._groupName;
 	}

src/sql/platform/connection/common/connectionProfileGroup.ts

@@ -195,10 +195,10 @@ export class ConnectionProfileGroup implements IConnectionProfileGroup {
 
 	public static getConnectionsInGroup(group: ConnectionProfileGroup): ConnectionProfile[] {
 		let connections = [];
-		if (group.connections) {
+		if (group && group.connections) {
 			group.connections.forEach((con) => connections.push(con));
 		}
-		if (group.children) {
+		if (group && group.children) {
 			group.children.forEach((subgroup) => {
 				connections = connections.concat(this.getConnectionsInGroup(subgroup));
 			});

src/sql/platform/connection/common/constants.ts

@@ -3,6 +3,8 @@
  *  Licensed under the Source EULA. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 
+import { localize } from 'vs/nls';
+
 // constants
 export const sqlConfigSectionName = 'sql';
 export const outputChannelName = 'MSSQL';
@@ -34,3 +36,7 @@ export const passwordChars = '***************';
 export const sqlLogin = 'SqlLogin';
 export const integrated = 'Integrated';
 export const azureMFA = 'AzureMFA';
+
+/* CMS constants */
+export const cmsProviderName = 'MSSQL-CMS';
+export const cmsProviderDisplayName = localize('constants.cmsProviderDisplayName', 'Microsoft SQL Server (CMS)');