ckaczor/azuredatastudio
1
0
Fork 0
mirror of https://github.com/ckaczor/azuredatastudio.git synced 2026-02-16 18:46:40 -05:00
Code Issues Packages Projects Releases Wiki Activity

withProperties -> withProps (#15876)

Browse Source 
* withProperties -> withProps

* Fix errors

* remove ,

* fixes

* Update azdata-test

* Fix dacpac tests

* Add required and remove added layout
This commit is contained in:
Charles Gagnon
2021-06-23 14:26:14 -07:00
committed by GitHub
parent e21f56d719
commit 3a3d7f5271
73 changed files with 417 additions and 414 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
extensions/dacpac/src/wizard/api/dacFxConfigPage.ts
View File

@@ -33,7 +33,7 @@ export abstract class DacFxConfigPage extends BasePage {
protected async createServerDropdown(isTargetServer: boolean): Promise<azdata.FormComponent> {
const serverDropDownTitle = isTargetServer ? loc.targetServer : loc.sourceServer;
this.serverDropdown = this.view.modelBuilder.dropDown().withProperties({
this.serverDropdown = this.view.modelBuilder.dropDown().withProps({
required: true,
ariaLabel: serverDropDownTitle
}).component();
@@ -79,7 +79,7 @@ export abstract class DacFxConfigPage extends BasePage {
protected async createDatabaseTextBox(title: string): Promise<azdata.FormComponent> {
this.databaseTextBox = this.view.modelBuilder.inputBox()
.withValidation(component => !this.databaseNameExists(component.value))
.withProperties({
.withProps({
required: true,
validationErrorMessage: loc.databaseNameExistsErrorMessage
}).component();
@@ -97,7 +97,7 @@ export abstract class DacFxConfigPage extends BasePage {
protected async createDatabaseDropdown(): Promise<azdata.FormComponent> {
const databaseDropdownTitle = loc.sourceDatabase;
this.databaseDropdown = this.view.modelBuilder.dropDown().withProperties({
this.databaseDropdown = this.view.modelBuilder.dropDown().withProps({
required: true,
ariaLabel: databaseDropdownTitle
}).component();
@@ -114,13 +114,12 @@ export abstract class DacFxConfigPage extends BasePage {
this.model.filePath = this.fileTextBox.value;
});
this.databaseLoader = this.view.modelBuilder.loadingComponent().withItem(this.databaseDropdown).withProperties({
required: true
}).component();
this.databaseLoader = this.view.modelBuilder.loadingComponent().withItem(this.databaseDropdown).component();
return {
component: this.databaseLoader,
title: databaseDropdownTitle
title: databaseDropdownTitle,
required: true
};
}
@@ -167,7 +166,7 @@ export abstract class DacFxConfigPage extends BasePage {
this.fileTextBox = this.view.modelBuilder.inputBox().withValidation(
component => isValidBasename(component.value)
)
.withProperties({
.withProps({
required: true,
ariaLive: 'polite'
}).component();