withProperties -> withProps (#15876)

* withProperties -> withProps

* Fix errors

* remove ,

* fixes

* Update azdata-test

* Fix dacpac tests

* Add required and remove added layout
This commit is contained in:
Charles Gagnon
2021-06-23 14:26:14 -07:00
committed by GitHub
parent e21f56d719
commit 3a3d7f5271
73 changed files with 417 additions and 414 deletions

View File

@@ -188,7 +188,7 @@ export class ManageAccessDialog {
.component();
contentContainer.addItem(addUserOrGroupTitle, { CSSStyles: { 'margin-top': '15px', ...cssStyles.titleCss } });
const typeContainer = this.modelBuilder.flexContainer().withProperties({ flexFlow: 'row' }).component();
const typeContainer = this.modelBuilder.flexContainer().component();
const aclEntryTypeGroup = 'aclEntryType';
const userTypeButton = this.createRadioButton(this.modelBuilder, loc.userLabel, aclEntryTypeGroup, AclType.user);
const groupTypeButton = this.createRadioButton(this.modelBuilder, loc.groupLabel, aclEntryTypeGroup, AclType.group);
@@ -197,7 +197,7 @@ export class ManageAccessDialog {
typeContainer.addItems([userTypeButton, groupTypeButton], { flex: '0 0 auto' });
contentContainer.addItem(typeContainer, { flex: '0 0 auto', CSSStyles: { 'margin-bottom': '5px' } });
const addUserOrGroupInputRow = this.modelBuilder.flexContainer().withLayout({ flexFlow: 'row' }).component();
const addUserOrGroupInputRow = this.modelBuilder.flexContainer().component();
this.addUserOrGroupInput = this.modelBuilder.inputBox()
.withProperties<azdata.InputBoxProperties>({
@@ -566,7 +566,7 @@ export class ManageAccessDialog {
// Only show default section for directories
if (this.hdfsModel.fileStatus.type === HdfsFileType.Directory) {
// Middle spacer
const middleSpacer = this.modelBuilder.text().withProperties({ CSSStyles: { 'width': `${middleSpacerWidth}px`, 'min-width': `${middleSpacerWidth}px` } }).component();
const middleSpacer = this.modelBuilder.text().withProps({ CSSStyles: { 'width': `${middleSpacerWidth}px`, 'min-width': `${middleSpacerWidth}px` } }).component();
sectionHeaderContainer.addItem(middleSpacer, { flex: '0 0 auto' });
// Default
@@ -586,7 +586,7 @@ export class ManageAccessDialog {
}
// Right spacer
const rightSpacer = this.modelBuilder.text().withProperties({ CSSStyles: { 'width': `${rightSpacerWidth}px`, 'min-width': `${rightSpacerWidth}px` } }).component();
const rightSpacer = this.modelBuilder.text().withProps({ CSSStyles: { 'width': `${rightSpacerWidth}px`, 'min-width': `${rightSpacerWidth}px` } }).component();
sectionHeaderContainer.addItem(rightSpacer, { flex: '0 0 auto' });
return sectionHeaderContainer;

View File

@@ -56,7 +56,7 @@ export class SparkConfigurationTab {
let formContainer = builder.formContainer();
this._jobNameInputBox = builder.inputBox().withProperties({
this._jobNameInputBox = builder.inputBox().withProps({
placeHolder: localize('sparkJobSubmission.JobNamePlaceHolder', "Enter a name ..."),
value: (this._path) ? fspath.basename(this._path) : ''
}).component();
@@ -67,7 +67,7 @@ export class SparkConfigurationTab {
required: true
}, baseFormItemLayout);
this._sparkContextLabel = builder.text().withProperties({
this._sparkContextLabel = builder.text().withProps({
value: this._dataModel.getSparkClusterUrl()
}).component();
formContainer.addFormItem({
@@ -104,7 +104,7 @@ export class SparkConfigurationTab {
}
});
this._sparkSourceFileInputBox = builder.inputBox().withProperties({
this._sparkSourceFileInputBox = builder.inputBox().withProps({
required: true,
placeHolder: localize('sparkJobSubmission.FilePathPlaceHolder', "Path to a .jar or .py file"),
value: (this._path) ? this._path : ''
@@ -133,8 +133,7 @@ export class SparkConfigurationTab {
}
});
this._filePickerButton = builder.button().withProperties({
required: (this._path) ? false : true,
this._filePickerButton = builder.button().withProps({
enabled: (this._path) ? false : true,
label: '•••',
width: constants.mssqlClusterSparkJobFileSelectorButtonWidth,
@@ -156,7 +155,7 @@ export class SparkConfigurationTab {
alignContent: 'stretch'
});
this._localUploadDestinationLabel = builder.text().withProperties({
this._localUploadDestinationLabel = builder.text().withProps({
value: (this._path) ? '' : LocalizedConstants.sparkLocalFileDestinationHint
}).component();
this._sourceFlexContainerWithHint = builder.flexContainer().component();